Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 11778043: Cleaning up Android's Autofill call suggestionSelected. (Closed)

Created:
7 years, 11 months ago by aurimas (slooooooooow)
Modified:
7 years, 11 months ago
Reviewers:
Ted C, Evan Stade
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Cleaning up Android's Autofill call suggestionSelected. Cleaning up Android's Autofill call suggestionSelected to remove unused parameters from the function. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175778

Patch Set 1 #

Patch Set 2 : Cleaning up AutofillPopup.java #

Patch Set 3 : Fixing the test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -34 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopup.java View 1 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillPopupGlue.java View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/test/AutofillTest.java View 1 2 2 chunks +4 lines, -10 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.h View 1 chunk +2 lines, -7 lines 0 comments Download
M chrome/browser/ui/android/autofill/autofill_popup_view_android.cc View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
aurimas (slooooooooow)
Hey Evan, Can you take a look at this CL? (the last one got corrupted ...
7 years, 11 months ago (2013-01-08 17:29:42 UTC) #1
aurimas (slooooooooow)
Hey Ted, Could you take a look at this CL? Thanks! Aurimas
7 years, 11 months ago (2013-01-08 17:47:04 UTC) #2
Ted C
lgtm
7 years, 11 months ago (2013-01-08 17:51:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/3001
7 years, 11 months ago (2013-01-08 17:55:15 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-08 18:31:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/15003
7 years, 11 months ago (2013-01-08 18:40:53 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:41:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/15003
7 years, 11 months ago (2013-01-08 18:43:49 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:47:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/15003
7 years, 11 months ago (2013-01-08 19:36:15 UTC) #10
Evan Stade
browser/ui/ lgtm, thanks.
7 years, 11 months ago (2013-01-08 21:22:14 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 03:18:39 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/15003
7 years, 11 months ago (2013-01-09 04:34:01 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) content_browsertests
7 years, 11 months ago (2013-01-09 07:36:33 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11778043/15003
7 years, 11 months ago (2013-01-09 08:50:40 UTC) #15
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 11:06:01 UTC) #16
Message was sent while issue was closed.
Change committed as 175778

Powered by Google App Engine
This is Rietveld 408576698