Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7872)

Unified Diff: chrome/test/chromedriver/run_java_tests.py

Issue 11778011: [chromedriver]Add a filter to run a subset of tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/run_all_tests.py ('k') | chrome/test/chromedriver/run_py_tests.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/run_java_tests.py
diff --git a/chrome/test/chromedriver/run_java_tests.py b/chrome/test/chromedriver/run_java_tests.py
index 692525675441f4ba60e06754fa45e1e7e8e14170..91bca23ca866aafa33f0f0d453f8af15316426c0 100755
--- a/chrome/test/chromedriver/run_java_tests.py
+++ b/chrome/test/chromedriver/run_java_tests.py
@@ -215,10 +215,10 @@ def PrintTestResults(results):
def main():
parser = optparse.OptionParser()
parser.add_option(
- '', '--chromedriver_path', type='string', default=None,
+ '', '--chromedriver', type='string', default=None,
help='Path to a build of the chromedriver library(REQUIRED!)')
parser.add_option(
- '', '--chrome_path', type='string', default=None,
+ '', '--chrome', type='string', default=None,
help='Path to a build of the chrome binary')
parser.add_option(
'', '--filter', type='string', default=None,
@@ -226,9 +226,8 @@ def main():
'AppCacheTest,ElementFindingTest#testShouldReturnTitleOfPageIfSet.')
options, args = parser.parse_args()
- if (options.chromedriver_path is None or
- not os.path.exists(options.chromedriver_path)):
- parser.error('chromedriver_path is required or the given path is invalid.' +
+ if (options.chromedriver is None or not os.path.exists(options.chromedriver)):
+ parser.error('chromedriver is required or the given path is invalid.' +
'Please run "%s --help" for help' % __file__)
# Run passed tests when filter is not provided.
@@ -252,8 +251,8 @@ def main():
src_dir=chrome_paths.GetSrc(),
java_tests_src_dir=java_tests_src_dir,
test_filter=test_filter,
- chromedriver_path=options.chromedriver_path,
- chrome_path=options.chrome_path))
+ chromedriver_path=options.chromedriver,
+ chrome_path=options.chrome))
if __name__ == '__main__':
« no previous file with comments | « chrome/test/chromedriver/run_all_tests.py ('k') | chrome/test/chromedriver/run_py_tests.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698