Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: media/mp4/mp4_stream_parser.cc

Issue 11778004: Convert a few LOG statements to MEDIA_LOG in MP4StreamParser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix compile error and add 0x to log messages Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mp4/mp4_stream_parser.cc
diff --git a/media/mp4/mp4_stream_parser.cc b/media/mp4/mp4_stream_parser.cc
index 69a35f28759090e5860c12cfc0bbd861971404eb..2c08dbabe3fce2c2d6030f33131d82e15334b963 100644
--- a/media/mp4/mp4_stream_parser.cc
+++ b/media/mp4/mp4_stream_parser.cc
@@ -196,12 +196,15 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {
if (!(entry.format == FOURCC_MP4A ||
(entry.format == FOURCC_ENCA &&
entry.sinf.format.format == FOURCC_MP4A))) {
- LOG(ERROR) << "Unsupported audio format.";
+ MEDIA_LOG(log_cb_) << "Unsupported audio format 0x"
+ << std::hex << entry.format << " in stsd box.";
return false;
}
// Check if it is MPEG4 AAC defined in ISO 14496 Part 3.
if (entry.esds.object_type != kISO_14496_3) {
- LOG(ERROR) << "Unsupported audio object type.";
+ MEDIA_LOG(log_cb_) << "Unsupported audio object type 0x" << std::hex
+ << static_cast<int>(entry.esds.object_type)
+ << " in esds.";
return false;
}
@@ -222,7 +225,8 @@ bool MP4StreamParser::ParseMoov(BoxReader* reader) {
if (!(entry.format == FOURCC_AVC1 ||
(entry.format == FOURCC_ENCV &&
entry.sinf.format.format == FOURCC_AVC1))) {
- LOG(ERROR) << "Unsupported video format.";
+ MEDIA_LOG(log_cb_) << "Unsupported video format 0x"
+ << std::hex << entry.format << " in stsd box.";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698