Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11777010: Set NULL if before releasing IBusUiController instance. (Closed)

Created:
7 years, 11 months ago by Seigo Nonaka
Modified:
7 years, 11 months ago
Reviewers:
satorux1
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Should reset handler before releasing IBusUiController instance. Otherwise IBusUiController will be used after freed by ibus operation sent from engine. BUG=168310 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175454

Patch Set 1 #

Patch Set 2 : Add condition check for testing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Seigo Nonaka
7 years, 11 months ago (2013-01-07 05:50:56 UTC) #1
satorux1
LGTM, but please describe why we should do this, in the patch description.
7 years, 11 months ago (2013-01-07 06:00:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11777010/1
7 years, 11 months ago (2013-01-07 06:24:48 UTC) #3
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 06:42:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11777010/2003
7 years, 11 months ago (2013-01-07 11:34:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 11:52:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nona@chromium.org/11777010/2003
7 years, 11 months ago (2013-01-08 00:00:41 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 01:28:23 UTC) #8
Message was sent while issue was closed. 
Change committed as 175454

Powered by Google App Engine
This is Rietveld 408576698