Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Side by Side Diff: content/public/browser/web_contents.h

Issue 11777009: Remove redundant |errored| member from IconHostMsg_DidDownloadFavicon (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/common/icon_messages.h ('k') | content/renderer/favicon_helper.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 6 #define CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/callback_forward.h" 9 #include "base/callback_forward.h"
10 #include "base/process_util.h" 10 #include "base/process_util.h"
(...skipping 405 matching lines...) Expand 10 before | Expand all | Expand 10 after
416 virtual bool FocusLocationBarByDefault() = 0; 416 virtual bool FocusLocationBarByDefault() = 0;
417 417
418 // Focuses the location bar. 418 // Focuses the location bar.
419 virtual void SetFocusToLocationBar(bool select_all) = 0; 419 virtual void SetFocusToLocationBar(bool select_all) = 0;
420 420
421 // Does this have an opener associated with it? 421 // Does this have an opener associated with it?
422 virtual bool HasOpener() const = 0; 422 virtual bool HasOpener() const = 0;
423 423
424 typedef base::Callback<void(int, /* id */ 424 typedef base::Callback<void(int, /* id */
425 const GURL&, /* image_url */ 425 const GURL&, /* image_url */
426 bool, /* errored */
427 int, /* requested_size */ 426 int, /* requested_size */
428 const std::vector<SkBitmap>& /* bitmaps*/)> 427 const std::vector<SkBitmap>& /* bitmaps*/)>
429 FaviconDownloadCallback; 428 FaviconDownloadCallback;
430 429
431 // Sends a request to download the given favicon |url| and returns the unique 430 // Sends a request to download the given favicon |url| and returns the unique
432 // id of the download request. When the download is finished, |callback| will 431 // id of the download request. When the download is finished, |callback| will
433 // be called with the bitmaps received from the renderer. Note that 432 // be called with the bitmaps received from the renderer. Note that
434 // |image_size| is a hint for images with multiple sizes. The downloaded image 433 // |image_size| is a hint for images with multiple sizes. The downloaded image
435 // is not resized to the given image_size. If 0 is passed, the first frame of 434 // is not resized to the given image_size. If 0 is passed, the first frame of
436 // the image is returned. 435 // the image is returned.
437 virtual int DownloadFavicon(const GURL& url, int image_size, 436 virtual int DownloadFavicon(const GURL& url, int image_size,
438 const FaviconDownloadCallback& callback) = 0; 437 const FaviconDownloadCallback& callback) = 0;
439 438
440 }; 439 };
441 440
442 } // namespace content 441 } // namespace content
443 442
444 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_ 443 #endif // CONTENT_PUBLIC_BROWSER_WEB_CONTENTS_H_
OLDNEW
« no previous file with comments | « content/common/icon_messages.h ('k') | content/renderer/favicon_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698