Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 11776034: Fix a couple test cases where we should be doing floating point comparisons. (Closed)

Created:
7 years, 11 months ago by Lei Zhang
Modified:
7 years, 11 months ago
Reviewers:
danakj
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Fix a couple test cases where we should be doing floating point comparisons. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M ui/gfx/vector2d_unittest.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M ui/gfx/vector3d_unittest.cc View 3 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lei Zhang
Official 32-bit Linux bot fails on these tests.
7 years, 11 months ago (2013-01-08 04:13:56 UTC) #1
danakj
Thanks, LGTM
7 years, 11 months ago (2013-01-08 15:56:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11776034/1
7 years, 11 months ago (2013-01-08 20:26:45 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 00:15:58 UTC) #4
Message was sent while issue was closed.
Change committed as 175620

Powered by Google App Engine
This is Rietveld 408576698