Fix RunPylint affected files regex issue

Fix RunPylint affected files regex issue

The AffectedSourceFiles query matches against files with paths relative
to repository root.  On the other hand _FindAllFiles checks white_lists
and black_lists against files paths relative to PRESUBMIT.py

As a result, when a PRESUBMIT.py is not at RepositoryRoot, RunPylint
can misbehave.

I fix this by modifying the white_lists and black_list regexes to
include the relative directory of PRESUBMIT.py.

Also adding some logging to pylint and simplified misc logic.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=175364

[M-A Ruel, 2013-01-07 15:32:46]

lgtm with some fixes. Thanks, I had totally overlooked that fact.

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
File presubmit_canned_checks.py (left):

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:690: if True:
While it's odd, leave it there. Because of issues inside pylint, it's
occasionally useful to run pylint independently on each files but I didn't see a
nice way to send a flag down here so I left the code as "never executed code".

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:657: input_api.logging.info('Running pylint on: %s',
files)
Put this comment after line 659?

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:666: extra_paths_list + sys.path)
That's a good idea. Should have done that before.

[Isaac (away), 2013-01-07 18:46:28]

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
File presubmit_canned_checks.py (left):

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:690: if True:
On 2013/01/07 15:32:46, Marc-Antoine Ruel wrote:
> While it's odd, leave it there. Because of issues inside pylint, it's
> occasionally useful to run pylint independently on each files but I didn't see
a
> nice way to send a flag down here so I left the code as "never executed code".

OK. I added a comment explaining the unreachable code.

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
File presubmit_canned_checks.py (right):

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:657: input_api.logging.info('Running pylint on: %s',
files)
On 2013/01/07 15:32:46, Marc-Antoine Ruel wrote:
> Put this comment after line 659?

Sure, done.

https://chromiumcodereview.appspot.com/11776016/diff/4001/presubmit_canned_ch...
presubmit_canned_checks.py:666: extra_paths_list + sys.path)
On 2013/01/07 15:32:46, Marc-Antoine Ruel wrote:
> That's a good idea. Should have done that before.

Yeah it lets us avoid a try/finally loop and importing sys in PRESUBMIT.py

[commit-bot: I haz the power, 2013-01-07 18:46:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ilevy@chromium.org/11776016/8001

[commit-bot: I haz the power, 2013-01-07 18:49:27]

Change committed as 175364