Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 11776006: mac: Attempt to fix startup regression after r174653 more (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Attempt to fix startup regression after r174653 more BUG=168084 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175274

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 chunk +1 line, -2 lines 5 comments Download

Messages

Total messages: 7 (0 generated)
Nico
7 years, 11 months ago (2013-01-04 21:50:59 UTC) #1
sail
https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (left): https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#oldcode176 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:176: bitmapFormat:NSAlphaFirstBitmapFormat Does this help because it prevents a format ...
7 years, 11 months ago (2013-01-04 22:03:35 UTC) #2
sail
Also, sorry for the comments just being questions. I guess what I'd like to know ...
7 years, 11 months ago (2013-01-04 22:05:04 UTC) #3
Nico
https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (left): https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#oldcode176 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:176: bitmapFormat:NSAlphaFirstBitmapFormat On 2013/01/04 22:03:35, sail wrote: > Does this ...
7 years, 11 months ago (2013-01-04 22:05:55 UTC) #4
sail
LGTM https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right): https://codereview.chromium.org/11776006/diff/1/chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm#newcode175 chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:175: colorSpaceName:NSDeviceRGBColorSpace On 2013/01/04 22:05:55, Nico wrote: > On ...
7 years, 11 months ago (2013-01-04 23:51:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/11776006/1
7 years, 11 months ago (2013-01-04 23:54:15 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 03:28:21 UTC) #7
Message was sent while issue was closed.
Change committed as 175274

Powered by Google App Engine
This is Rietveld 408576698