Issue 11775013: Remove redundant android buildbot step annotation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11775013: Remove redundant android buildbot step annotation (Closed)

Created:
7 years, 11 months ago by Isaac (away)

Modified:
7 years, 11 months ago

Reviewers:
frankf

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove redundant android buildbot step annotation It is preferrable to print buildbot step annotations before calling tester runners so that the call is listed in the proper step. This patch removes the step annotation printed by the test runner inself. BUG=161993 R=frankf@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175861

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	build/android/run_instrumentation_tests.py	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

frankf

LGTM. Thanks ilevy. https://codereview.chromium.org/11775013/diff/1/build/android/run_instrumentation_tests.py File build/android/run_instrumentation_tests.py (right): https://codereview.chromium.org/11775013/diff/1/build/android/run_instrumentation_tests.py#newcode80 build/android/run_instrumentation_tests.py:80: buildbot_report.PrintStepResultIfNeeded(options, ret) Next up: removing this.

7 years, 11 months ago (2013-01-07 18:58:36 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ilevy@chromium.org/11775013/5001

7 years, 11 months ago (2013-01-09 19:38:01 UTC) #3

Message was sent while issue was closed.

Change committed as 175861

Expand Messages | Collapse Messages