Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11775012: Add Histogram record to SadTabGtk (Closed)

Created:
7 years, 11 months ago by simonhong_
Modified:
7 years, 11 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add Histogram to SadTabGtk BUG=NONE TEST=Compiles and test chrome://histograms/Tabs.SadTab Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175490

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M chrome/browser/ui/gtk/sad_tab_gtk.cc View 3 chunks +35 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
simonhong_
Dear Elliot Please review this patch. Thank you.
7 years, 11 months ago (2013-01-06 05:00:18 UTC) #1
Elliot Glaysher
+jamescook who added the histograms to views. James, do we want these on gtk too? ...
7 years, 11 months ago (2013-01-07 18:10:12 UTC) #2
James Cook
LGTM. This might be useful on GTK as it will give us more insight into ...
7 years, 11 months ago (2013-01-07 18:27:51 UTC) #3
Elliot Glaysher
On 2013/01/07 18:27:51, James Cook (Chromium) wrote: > LGTM. This might be useful on GTK ...
7 years, 11 months ago (2013-01-07 18:33:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11775012/1
7 years, 11 months ago (2013-01-07 21:30:41 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-08 00:00:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simon.hong81@gmail.com/11775012/1
7 years, 11 months ago (2013-01-08 04:03:11 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 06:09:57 UTC) #8
Message was sent while issue was closed.
Change committed as 175490

Powered by Google App Engine
This is Rietveld 408576698