Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 11775008: [net] Set default HostCache size to 1000 entries. (Closed)

Created:
7 years, 11 months ago by szym
Modified:
7 years, 11 months ago
Reviewers:
cbentzel
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

[net] Set default HostCache size to 1000 entries. BUG=114277 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176410

Patch Set 1 #

Patch Set 2 : restrict increase to platforms which support built-in DNS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M net/base/host_cache.cc View 1 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
szym
We could probably go higher to completely eliminate evictions, but don't want to lock too ...
7 years, 11 months ago (2013-01-10 21:25:08 UTC) #1
cbentzel
What's the memory impact?
7 years, 11 months ago (2013-01-10 22:39:36 UTC) #2
szym
On 2013/01/10 22:39:36, cbentzel wrote: > What's the memory impact? Quoting http://crbug.com/114277#c25 I estimate the ...
7 years, 11 months ago (2013-01-10 22:57:37 UTC) #3
cbentzel
LGTM
7 years, 11 months ago (2013-01-11 16:53:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szym@chromium.org/11775008/7001
7 years, 11 months ago (2013-01-11 17:04:41 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-11 19:26:52 UTC) #6
Message was sent while issue was closed.
Change committed as 176410

Powered by Google App Engine
This is Rietveld 408576698