Issue 11770002: Fix crash when translated ANGLE shader source has length zero.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11770002: Fix crash when translated ANGLE shader source has length zero. (Closed)

Created:
7 years, 11 months ago by apatrick_chromium

Modified:
7 years, 11 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews, apatrick_chromium, greggman

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Fix crash when translated ANGLE shader source has length zero. BUG=153048 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175106

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	gpu/command_buffer/service/program_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

Ken Russell (switch to Gerrit)

LGTM Per our offline discussion I wonder whether a defensive change in ProgramManager::ProgramInfo::Update (near the ...

7 years, 11 months ago (2013-01-04 03:05:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/11770002/1

7 years, 11 months ago (2013-01-04 03:10:46 UTC) #4

Message was sent while issue was closed.

Change committed as 175106