Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 11766002: Launch non-shortcut apps in ChromeLauncherControllerPerApp (Closed)

Created:
7 years, 11 months ago by stevenjb
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Launch non-shortcut apps in ChromeLauncherControllerPerApp BUG=168244 Owner: TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175655

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_app.cc View 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
stevenjb
skuhne@ - I'm not 100% certain this is the correct fix (since I'm not certain ...
7 years, 11 months ago (2013-01-03 22:07:50 UTC) #1
Mr4D (OOO till 08-26)
lgtm Looks good to me!
7 years, 11 months ago (2013-01-08 16:00:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11766002/1
7 years, 11 months ago (2013-01-08 18:05:08 UTC) #3
commit-bot: I haz the power
Presubmit check for 11766002-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-08 18:05:10 UTC) #4
stevenjb
TBR=sky@chromium.org
7 years, 11 months ago (2013-01-08 18:33:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11766002/1
7 years, 11 months ago (2013-01-08 18:34:00 UTC) #6
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 18:37:07 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11766002/19001
7 years, 11 months ago (2013-01-08 19:03:36 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 11 months ago (2013-01-08 19:07:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11766002/19001
7 years, 11 months ago (2013-01-08 20:47:10 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 01:47:08 UTC) #11
Message was sent while issue was closed.
Change committed as 175655

Powered by Google App Engine
This is Rietveld 408576698