Implementing native chromium GeolocationPermissionContext

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
@@ skipping 26 matching lines @@
       const GURL& server_url, const string16& access_token) OVERRIDE { }
 
   DISALLOW_COPY_AND_ASSIGN(DummyAccessTokenStore);
 };
 
 }
 
 namespace android_webview {
 
 AwContentBrowserClient::AwContentBrowserClient(
-    ViewDelegateFactoryFn* view_delegate_factory)
+    ViewDelegateFactoryFn* view_delegate_factory,
+    content::GeolocationPermissionContext* geolocation_permission_context)

[benm (inactive), 2013/01/04 11:35:52]

Why does this need to come in as a param here? Couldn't we just new one up
inside AwBrowserContext the first time the getter is called?

[boliu, 2013/01/04 16:42:05]

That would lead to a DEPS violation since AwBrowserContext is in browser/ and
cannot include AwGeolocationPermisssionContext which is in native/.

Although I still vote for passing in a "FactoryFn" so it can be created lazily.
We can refactor into a true factory interface when we collect enough of these.

[Kristian Monsen, 2013/01/04 17:13:46]

Right now lazy instantiation would not get anything except increased code
complexity as the factory would have to be created at the same time.

Unless you have something else that you want to use it for right now I think it
is best to wait until it is needed. I don't know which other kinds of objects
the factory should create.

[boliu, 2013/01/04 17:17:30]

I was suggesting FactoryFn (ie function pointer) in this CL, basically just copy
ViewDelegateFactoryFn. Refactoring to a real factory class comes later.

[Kristian Monsen, 2013/01/04 22:54:31]

Updated to do this, take a look and see if this was what you were thinking.

     : view_delegate_factory_(view_delegate_factory) {
   FilePath user_data_dir;
   if (!PathService::Get(base::DIR_ANDROID_APP_DATA, &user_data_dir)) {
     NOTREACHED() << "Failed to get app data directory for Android WebView";
   }
-  browser_context_.reset(new AwBrowserContext(user_data_dir));
+  browser_context_.reset(
+      new AwBrowserContext(user_data_dir, geolocation_permission_context));
 }
 
 AwContentBrowserClient::~AwContentBrowserClient() {
 }
 
 AwBrowserContext* AwContentBrowserClient::GetAwBrowserContext() {
   return browser_context_.get();
 }
 
 content::BrowserMainParts* AwContentBrowserClient::CreateBrowserMainParts(
@@ skipping 269 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview