Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 11761038: Fix shutdown race in IPCSyncChannelTest and get rid of "suppressions"/annotations. (Closed)

Created:
7 years, 11 months ago by viettrungluu
Modified:
7 years, 11 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix shutdown race in IPCSyncChannelTest and get rid of "suppressions"/annotations. Shut down explicitly, rather than doing it in a virtual destructor, which leads to a vtable race. (Possibly also related is http://crbug.com/70075, but I haven't been able to reproduce, so I'll try to re-enable that separately.) BUG=25841 TEST=ipc_tests + TSAN still happy Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175487

Patch Set 1 #

Patch Set 2 : agh #

Patch Set 3 : agh2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M ipc/ipc.gyp View 1 2 3 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 7 chunks +28 lines, -25 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
viettrungluu
7 years, 11 months ago (2013-01-04 23:16:25 UTC) #1
jam
lgtm
7 years, 11 months ago (2013-01-04 23:44:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/1
7 years, 11 months ago (2013-01-04 23:53:51 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-05 00:22:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/8003
7 years, 11 months ago (2013-01-05 00:41:18 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 11 months ago (2013-01-05 01:17:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-05 06:57:11 UTC) #7
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 07:11:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-05 17:22:48 UTC) #9
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-05 17:31:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-06 08:17:04 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-06 08:25:44 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-07 00:53:05 UTC) #13
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 01:01:45 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-07 07:36:07 UTC) #15
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests, unit_tests
7 years, 11 months ago (2013-01-07 07:52:45 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-07 17:52:04 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_aura for step(s) interactive_ui_tests
7 years, 11 months ago (2013-01-07 20:16:18 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/viettrungluu@chromium.org/11761038/3003
7 years, 11 months ago (2013-01-08 00:38:50 UTC) #19
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 06:09:08 UTC) #20
Message was sent while issue was closed.
Change committed as 175487

Powered by Google App Engine
This is Rietveld 408576698