Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 11761031: Document the limitations on chrome.alarms timing. (Closed)

Created:
7 years, 11 months ago by Jeffrey Yasskin
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Document the limitations on chrome.alarms timing. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175277

Patch Set 1 #

Total comments: 10

Patch Set 2 : Fix kalman's wording tweaks #

Total comments: 8

Patch Set 3 : Fix mkearney's comments #

Patch Set 4 : Remove redundant description bit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M chrome/common/extensions/docs/templates/intros/alarms.html View 1 2 3 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
Jeffrey Yasskin
This could probably use some wordsmithing, but it's a start. It's in response to https://groups.google.com/a/chromium.org/d/topic/chromium-extensions/0XgFNSy37_Y/discussion
7 years, 11 months ago (2013-01-04 02:06:00 UTC) #1
not at google - send to devlin
lgtm, various optional suggestions. https://codereview.chromium.org/11761031/diff/1/chrome/common/extensions/docs/templates/intros/alarms.html File chrome/common/extensions/docs/templates/intros/alarms.html (right): https://codereview.chromium.org/11761031/diff/1/chrome/common/extensions/docs/templates/intros/alarms.html#newcode27 chrome/common/extensions/docs/templates/intros/alarms.html:27: periodically. In order to reduce ...
7 years, 11 months ago (2013-01-04 22:36:57 UTC) #2
Jeffrey Yasskin
https://codereview.chromium.org/11761031/diff/1/chrome/common/extensions/docs/templates/intros/alarms.html File chrome/common/extensions/docs/templates/intros/alarms.html (right): https://codereview.chromium.org/11761031/diff/1/chrome/common/extensions/docs/templates/intros/alarms.html#newcode27 chrome/common/extensions/docs/templates/intros/alarms.html:27: periodically. In order to reduce the load on the ...
7 years, 11 months ago (2013-01-04 22:51:16 UTC) #3
mkearney1
https://codereview.chromium.org/11761031/diff/5001/chrome/common/extensions/docs/templates/intros/alarms.html File chrome/common/extensions/docs/templates/intros/alarms.html (right): https://codereview.chromium.org/11761031/diff/5001/chrome/common/extensions/docs/templates/intros/alarms.html#newcode24 chrome/common/extensions/docs/templates/intros/alarms.html:24: </table> What does this look like right under the ...
7 years, 11 months ago (2013-01-04 22:59:52 UTC) #4
Jeffrey Yasskin
https://codereview.chromium.org/11761031/diff/5001/chrome/common/extensions/docs/templates/intros/alarms.html File chrome/common/extensions/docs/templates/intros/alarms.html (right): https://codereview.chromium.org/11761031/diff/5001/chrome/common/extensions/docs/templates/intros/alarms.html#newcode24 chrome/common/extensions/docs/templates/intros/alarms.html:24: </table> On 2013/01/04 22:59:52, mkearney1 wrote: > What does ...
7 years, 11 months ago (2013-01-04 23:19:52 UTC) #5
mkearney1
lgtm
7 years, 11 months ago (2013-01-04 23:27:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jyasskin@chromium.org/11761031/5003
7 years, 11 months ago (2013-01-04 23:35:09 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-05 03:33:31 UTC) #8
Message was sent while issue was closed.
Change committed as 175277

Powered by Google App Engine
This is Rietveld 408576698