Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 11761026: Add missing string16 #include (Closed)

Created:
7 years, 11 months ago by Ilya Sherman
Modified:
7 years, 11 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, Raman Kakilate, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

Add missing string16 #include In theory the #include could be replaced with a forward declaration. However, forward declaring string16 is more bother than it's worth, since at least on some platforms it's a typedef rather than a proper class. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175130

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Ilya Sherman
7 years, 11 months ago (2013-01-03 23:54:33 UTC) #1
Evan Stade
lgtm -- Evan Stade On Thu, Jan 3, 2013 at 3:54 PM, <isherman@chromium.org> wrote: > ...
7 years, 11 months ago (2013-01-04 02:18:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/11761026/1
7 years, 11 months ago (2013-01-04 07:06:48 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 12:16:58 UTC) #4
Message was sent while issue was closed.
Change committed as 175130

Powered by Google App Engine
This is Rietveld 408576698