Issue 11759022: Check for read-only-ness when preparing for array sort.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11759022: Check for read-only-ness when preparing for array sort. (Closed)

Created:
7 years, 11 months ago by Yang

Modified:
7 years, 11 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check for read-only-ness when preparing for array sort. R=verwaest@chromium.org BUG=v8:2419 Committed: https://code.google.com/p/v8/source/detail?r=13313

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	src/objects.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	A +	test/mjsunit/regress/regress-2419.js	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

7 years, 11 months ago (2013-01-04 15:12:45 UTC) #2

LGTM, except that this probably (at least) also needs to handle AccessChecks,
and support observers and interceptors. This can be handled in a separate CL
however.

Expand Messages | Collapse Messages