[NaCl SDK] Update sdk_tools to 160493->174973. Also added script to make updating sdk_tools easier.

[NaCl SDK] Update sdk_tools to 160493->174973. Also added script to make updating sdk_tools easier.

BUG=none
R=noelallen@chromium.org
NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175860

[binji, 2013-01-08 21:43:29]

ping

[noelallen1, 2013-01-08 23:22:57]

A few nits and questions otherwise LGTM.

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/update_sdktools.py (right):

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:26: from
update_nacl_manifest import RealDelegate
optional seperate CL:  The name RealDelegate is unfortunate because it provides
no insight into what the object does.  Delegate and RealDelegate should probably
be there own py files instead of living in update_nacl_manifest.  Refactoring
that interface would make this CL more readable.
Maybe  "VersionedStorage"?

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:50: def
FindMostRecentSdkTools(delegate):
Why is this called MostRecentSdkTools?  I don't see how this is limited to the
tools bundle.   Could you rename or comment?

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:99: print 'diff %s' %
filename
Did you mean to print this, or is this just diagnostic?

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:112: 
nit: assert args = 0 instead of silently dropping args?

[binji, 2013-01-09 19:13:24]

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
File native_client_sdk/src/build_tools/update_sdktools.py (right):

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:26: from
update_nacl_manifest import RealDelegate
On 2013/01/08 23:22:57, noelallen1 wrote:
> optional seperate CL:  The name RealDelegate is unfortunate because it
provides
> no insight into what the object does.  Delegate and RealDelegate should
probably
> be there own py files instead of living in update_nacl_manifest.  Refactoring
> that interface would make this CL more readable.
> Maybe  "VersionedStorage"?

Added TODO with bug# below.

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:50: def
FindMostRecentSdkTools(delegate):
On 2013/01/08 23:22:57, noelallen1 wrote:
> Why is this called MostRecentSdkTools?  I don't see how this is limited to the
> tools bundle.   Could you rename or comment?

Done.

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:99: print 'diff %s' %
filename
On 2013/01/08 23:22:57, noelallen1 wrote:
> Did you mean to print this, or is this just diagnostic?

I think it is useful output, but I can hide it behind a flag if you prefer.

https://codereview.chromium.org/11759011/diff/1/native_client_sdk/src/build_t...
native_client_sdk/src/build_tools/update_sdktools.py:112: 
On 2013/01/08 23:22:57, noelallen1 wrote:
> nit: assert args = 0 instead of silently dropping args?

Done.

[commit-bot: I haz the power, 2013-01-09 19:14:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/binji@chromium.org/11759011/6001

[commit-bot: I haz the power, 2013-01-09 19:57:11]

Change committed as 175860