Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 11756002: Move cros_network_functions.cc to src/chromeos (Closed)

Created:
7 years, 11 months ago by stevenjb
Modified:
7 years, 11 months ago
CC:
chromium-reviews, dbeam+watch-options_chromium.org, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move cros_network_functions.cc to src/chromeos We have some code that should be moved to src/content which needs to query network state (crbug.com/156428). While we transition to the new network handlers, we will need to make Cros* calls when the --enable-new-network-handlers flag is not set. To do that we need cros_network_functions.cc (and its dependencies) moved to src/chromeos, where they belong anyway. BUG=154852 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175087

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Clang fixes #

Patch Set 4 : Clang fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+422 lines, -3075 lines) Patch
D chrome/browser/chromeos/cros/cros_network_functions.h View 1 chunk +0 lines, -300 lines 0 comments Download
D chrome/browser/chromeos/cros/cros_network_functions.cc View 1 chunk +0 lines, -830 lines 0 comments Download
D chrome/browser/chromeos/cros/cros_network_functions_unittest.cc View 1 chunk +0 lines, -1034 lines 0 comments Download
D chrome/browser/chromeos/cros/network_ip_config.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/chromeos/cros/network_ip_config.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 2 chunks +3 lines, -1 line 0 comments Download
D chrome/browser/chromeos/cros/sms_watcher.h View 1 chunk +0 lines, -67 lines 0 comments Download
D chrome/browser/chromeos/cros/sms_watcher.cc View 1 chunk +0 lines, -409 lines 0 comments Download
M chrome/browser/chromeos/sms_observer.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/sms_observer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos.gyp View 4 chunks +10 lines, -0 lines 0 comments Download
A + chromeos/network/cros_network_functions.h View 7 chunks +98 lines, -123 lines 0 comments Download
A + chromeos/network/cros_network_functions.cc View 5 chunks +4 lines, -78 lines 0 comments Download
A + chromeos/network/cros_network_functions_unittest.cc View 1 2 chunks +3 lines, -92 lines 0 comments Download
A + chromeos/network/network_ip_config.h View 3 chunks +5 lines, -4 lines 0 comments Download
A + chromeos/network/network_ip_config.cc View 1 chunk +1 line, -1 line 0 comments Download
A chromeos/network/network_util.h View 1 2 1 chunk +78 lines, -0 lines 0 comments Download
A chromeos/network/network_util.cc View 1 2 1 chunk +96 lines, -0 lines 0 comments Download
A chromeos/network/network_util_unittest.cc View 1 chunk +101 lines, -0 lines 0 comments Download
A + chromeos/network/sms_watcher.h View 3 chunks +6 lines, -5 lines 0 comments Download
A + chromeos/network/sms_watcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
stevenjb
gspencer@ - I'm moving these now because we don't want to wait until their deprecated ...
7 years, 11 months ago (2013-01-02 21:25:55 UTC) #1
jam
lgtm, thanks
7 years, 11 months ago (2013-01-02 21:43:07 UTC) #2
Greg Spencer (Chromium)
lgtm
7 years, 11 months ago (2013-01-03 21:46:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11756002/8002
7 years, 11 months ago (2013-01-03 23:34:33 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 02:27:53 UTC) #5
Message was sent while issue was closed.
Change committed as 175087

Powered by Google App Engine
This is Rietveld 408576698