Chromium Code Reviews Chromium Code Reviews
Issue
11753023:
[telemetry] Clean up image decoding benchmark (Closed)
Description[telemetry] Clean up image decoding benchmark
The image decoding benchmark still contained some logic for navigation/test
control. The image_decoding_benchmark should measure image decodign times. Critically, the
logic to make chrome/test/data/image_decoding/image_decoding.html do its work
should be handled by the page runner, not the benchmark. To make this
separation happen, three changes are made...
First, page runner now notifies the test that naivgation will happen. This
allows us to begin recording the timeline right before navigation. This is when timeline
recording should begin for image decode tests.
Second, this adds a post_navigate_javascript_to_execute method to the page. This allows us to
call runBenchmark() on the image decoding benchmarks after we navigate.
Finally, the benchmark uses the standard wait_for_javascript_expression to poll
the isDone variable.The old code actually did this in python.
R=tonyg
NOTRY=True
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175404
Patch Set 1 #Patch Set 2 : helps if i upload a working patch #
Total comments: 2
Patch Set 3 : Two pagesets #
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
