Issue 11748033: Only enable MinGW-w64 pow() workaround if needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11748033: Only enable MinGW-w64 pow() workaround if needed (Closed)

Created:
7 years, 11 months ago by Net147

Modified:
7 years, 11 months ago

Reviewers:
ulan, alexeif, Yang

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Only enable MinGW-w64 pow() workaround if needed The pow() workaround is no longer needed in the latest version of MinGW-w64. Contributed by net147@gmail.com BUGS= TEST=mjsunit/math-pow,mjsunit/math-sqrt Committed: https://code.google.com/p/v8/source/detail?r=13334

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/assembler.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Net147

Updated patch to not generate warning if compiling with -Wundef when __MINGW64_VERSION_RC is not defined.

7 years, 11 months ago (2013-01-05 00:59:12 UTC) #2

Yang

7 years, 11 months ago (2013-01-08 15:28:24 UTC) #3

On 2013/01/05 00:59:12, Net147 wrote:
> Updated patch to not generate warning if compiling with -Wundef when
> __MINGW64_VERSION_RC is not defined.

Thanks for your contribution! LGTM except for line break, which I will fix befor
I land this patch.

Expand Messages | Collapse Messages