mac: Attempt to fix a startup perf regression caused by r174778

mac: Attempt to fix a startup perf regression caused by r174778

NOTRY=true
BUG=167798, 168084
TEST=Install https://chrome.google.com/webstore/detail/slinky-elegant/bmanlajnpdncmhfkiccmbgeocgbncfln?hl=en
Look at new tab button in active and inactive windows. Also check the new tab
button with the default theme. Look at startup perf graphs, should improve by
~1.8ms.


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175108

[Nico, 2013-01-04 01:12:10]

I have no idea if this will help, but it reverts the only perf-related part of
r174653, so it should?

[sail, 2013-01-04 01:22:10]

On 2013/01/04 01:12:10, Nico wrote:
> I have no idea if this will help, but it reverts the only perf-related part of
> r174653, so it should?

Weird, I would have thought that the CreateImageWithSize() and ApplyMask()
functions would have caused the regressions.

[sail, 2013-01-04 01:23:32]

lgtm

https://codereview.chromium.org/11748026/diff/1/chrome/browser/ui/cocoa/tabs/...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/11748026/diff/1/chrome/browser/ui/cocoa/tabs/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:210: [image size].height -
height - kYOffset,
could cache this above as well

[Nico, 2013-01-04 01:25:19]

On Thu, Jan 3, 2013 at 5:22 PM,  <sail@chromium.org> wrote:
> On 2013/01/04 01:12:10, Nico wrote:
>>
>> I have no idea if this will help, but it reverts the only perf-related
>> part of
>> r174653, so it should?
>
>
> Weird, I would have thought that the CreateImageWithSize() and ApplyMask()
> functions would have caused the regressions.

Sorry, I pasted the wrong revision number. I meant r174778.

>
> https://codereview.chromium.org/11748026/

[Nico, 2013-01-04 01:29:51]

https://codereview.chromium.org/11748026/diff/1/chrome/browser/ui/cocoa/tabs/...
File chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm (right):

https://codereview.chromium.org/11748026/diff/1/chrome/browser/ui/cocoa/tabs/...
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm:210: [image size].height -
height - kYOffset,
On 2013/01/04 01:23:32, sail wrote:
> could cache this above as well

That hopefully isn't necessary (because a) the compiler might do it b) it should
be much much much faster than milliseconds)

[commit-bot: I haz the power, 2013-01-04 01:57:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11748026/1

[commit-bot: I haz the power, 2013-01-04 05:22:32]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-04 05:43:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11748026/1

[commit-bot: I haz the power, 2013-01-04 05:48:02]

Change committed as 175108