Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 11747020: Cleanup: Remove using statements from webkit/fileapi header files. (Closed)

Created:
7 years, 11 months ago by Lei Zhang
Modified:
7 years, 11 months ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Cleanup: Remove using statements from webkit/fileapi header files. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175498

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -123 lines) Patch
M webkit/fileapi/file_system_context.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_dir_url_request_job_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M webkit/fileapi/file_system_file_util.h View 8 chunks +14 lines, -18 lines 0 comments Download
M webkit/fileapi/file_system_file_util_proxy.h View 2 chunks +2 lines, -10 lines 0 comments Download
M webkit/fileapi/isolated_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_file_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_mount_point_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/fileapi/local_file_util.h View 3 chunks +16 lines, -28 lines 0 comments Download
M webkit/fileapi/local_file_util.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M webkit/fileapi/media/device_media_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/media/device_media_file_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/media/mtp_device_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/fileapi/media/native_media_file_util.h View 1 chunk +9 lines, -9 lines 0 comments Download
M webkit/fileapi/media/native_media_file_util.cc View 1 chunk +1 line, -3 lines 0 comments Download
M webkit/fileapi/native_file_util.h View 1 chunk +19 lines, -22 lines 0 comments Download
M webkit/fileapi/native_file_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.h View 4 chunks +3 lines, -5 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webkit/fileapi/obfuscated_file_util_unittest.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download
M webkit/fileapi/test_mount_point_provider.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
7 years, 11 months ago (2013-01-04 23:19:46 UTC) #1
kinuko
looks good, but I thought using for individual type names was ok (contrary to 'using ...
7 years, 11 months ago (2013-01-07 03:23:01 UTC) #2
Lei Zhang
The style guide says, "You may use a using-declaration anywhere in a .cc file, and ...
7 years, 11 months ago (2013-01-07 22:22:17 UTC) #3
kinuko
Oh sorry you're removing them from headers. Sure, we should do that. LGTM Thanks!
7 years, 11 months ago (2013-01-08 02:32:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/11747020/1026
7 years, 11 months ago (2013-01-08 02:35:17 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 07:51:44 UTC) #6
Message was sent while issue was closed.
Change committed as 175498

Powered by Google App Engine
This is Rietveld 408576698