Issue 11747016: Add support for high DPI favicons on the "other devices" menu.

Issue 11747016: Add support for high DPI favicons on the "other devices" menu. (Closed)

Created:
7 years, 11 months ago by kevers

Modified:
7 years, 11 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, arv (Not doing code reviews), pedrosimonetti+watch_chromium.org, pkotwicz, Nico, Patrick Dubroy

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add support for high DPI favicons on the "other devices" menu. BUG=152731 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175154

Patch Set 2 : Fix ordering in header file. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -44 lines)			Patch
M	chrome/browser/resources/ntp4/other_sessions.js	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/resources/shared/js/util.js	View		1 chunk	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/favicon_source.h	View	1	1 chunk	+26 lines, -14 lines	0 comments	Download
M	chrome/browser/ui/webui/favicon_source.cc	View		4 chunks	+19 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/session_favicon_source.h	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/ui/webui/session_favicon_source.cc	View		2 chunks	+19 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevers

Hi Evan, Can you please take a look at this CL. The ordering of checks ...

7 years, 11 months ago (2013-01-03 22:42:03 UTC) #1

Evan Stade

lgtm https://chromiumcodereview.appspot.com/11747016/diff/1/chrome/browser/ui/webui/favicon_source.h File chrome/browser/ui/webui/favicon_source.h (right): https://chromiumcodereview.appspot.com/11747016/diff/1/chrome/browser/ui/webui/favicon_source.h#newcode53 chrome/browser/ui/webui/favicon_source.h:53: Profile* profile_; please put data members, type definitions ...

7 years, 11 months ago (2013-01-04 01:42:11 UTC) #2

kevers

https://chromiumcodereview.appspot.com/11747016/diff/1/chrome/browser/ui/webui/favicon_source.h File chrome/browser/ui/webui/favicon_source.h (right): https://chromiumcodereview.appspot.com/11747016/diff/1/chrome/browser/ui/webui/favicon_source.h#newcode53 chrome/browser/ui/webui/favicon_source.h:53: Profile* profile_; On 2013/01/04 01:42:11, Evan Stade wrote: > ...

7 years, 11 months ago (2013-01-04 16:24:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/11747016/4001

7 years, 11 months ago (2013-01-04 16:24:32 UTC) #4

Message was sent while issue was closed.

Change committed as 175154

Expand Messages | Collapse Messages