Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 11746029: Cause Chrome Frame to follow the fast shutdown path, which cleans up infobars and avoids a crash on… (Closed)

Created:
7 years, 11 months ago by robertshield
Modified:
7 years, 11 months ago
Reviewers:
ananta, sky
CC:
chromium-reviews, tfarina, erikwright (departed)
Visibility:
Public.

Description

Cause Chrome Frame to follow the fast shutdown path, which cleans up infobars and avoids a crash on shutdown. Chrome Frame Android were the only remaining things in Chrome that appear not to use the fast shutdown path and afaict the non-fast shutdown path no longer works. BUG=148398 TEST=Visit hyves.nl or some other CF-aware site that pops up a translation bar in CF. Close IE, using an attached debugger or your mechanism of choice observe that Chrome doesn't crash during shutdown. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
robertshield
Ananta, please could you take a look.
7 years, 11 months ago (2013-01-04 15:53:00 UTC) #1
ananta
lgtm
7 years, 11 months ago (2013-01-04 18:23:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11746029/1
7 years, 11 months ago (2013-01-04 18:33:39 UTC) #3
commit-bot: I haz the power
Presubmit check for 11746029-1 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-04 18:33:42 UTC) #4
robertshield
TBRing sky for OWNERs as the bug this fixes is currently causing a large volume ...
7 years, 11 months ago (2013-01-04 18:37:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/11746029/1
7 years, 11 months ago (2013-01-04 18:37:58 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 20:23:10 UTC) #7
Message was sent while issue was closed.
Change committed as 175182

Powered by Google App Engine
This is Rietveld 408576698