Initial DEPS setup to make VisitedLink into Browser Component

Initial DEPS setup to make VisitedLink into Browser Component

DEPS rules to make visitedlink independent of chrome/browser except chrome/browser/[api, common]

BUG=none


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175883

[Gajen, 2013-01-04 00:54:30]

PTAL,
If this component is agreed for browser component inclusion, then next immediate
action, I, expect would be decoupling it from
chrome/renderer/visitedlink_slave.h first.

[Jói, 2013-01-04 08:53:08]

This DEPS file seems fine as a step towards making VisitedLink a component. 
Note that boliu@chromium.org has a change in flight to componentize VisitedLink
(https://codereview.chromium.org/11573060/) so am adding him as a reviewer.

LGTM as a step towards componentizing it, even if this version of the file may
be short-lived.

Cheers,
Jói

https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DEPS
File chrome/browser/visitedlink/DEPS (right):

https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DE...
chrome/browser/visitedlink/DEPS:10: # TODO(Gajen): Bring this list to zero.
TODOs should usually have your email address so others can contact you with
questions about the TODO.

[boliu, 2013-01-04 15:49:49]

lgtm

Fyi, my goal is to componentize all of visitedlink, including common and
renderer/slave part, so they can be re-used by android_webview.

[Gajen, 2013-01-05 02:22:56]

https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DEPS
File chrome/browser/visitedlink/DEPS (right):

https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DE...
chrome/browser/visitedlink/DEPS:10: # TODO(Gajen): Bring this list to zero.
On 2013/01/04 08:53:08, Jói wrote:
> TODOs should usually have your email address so others can contact you with
> questions about the TODO.

Done.

[Jói, 2013-01-07 12:22:44]

LGTM

On Sat, Jan 5, 2013 at 2:22 AM,  <wxjg68@motorola.com> wrote:
>
>
https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DEPS
> File chrome/browser/visitedlink/DEPS (right):
>
>
https://codereview.chromium.org/11746027/diff/1/chrome/browser/visitedlink/DE...
> chrome/browser/visitedlink/DEPS:10: # TODO(Gajen): Bring this list to
> zero.
> On 2013/01/04 08:53:08, Jói wrote:
>>
>> TODOs should usually have your email address so others can contact you
>
> with
>>
>> questions about the TODO.
>
>
> Done.
>
> https://codereview.chromium.org/11746027/

[Gajen, 2013-01-09 14:36:24]

Can someone put this into trybot..as I don't have that access.

[commit-bot: I haz the power, 2013-01-09 15:06:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wxjg68@motorola.com/11746027/5001

[commit-bot: I haz the power, 2013-01-09 15:06:27]

Presubmit check for 11746027-5001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/visitedlink

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[Ben Goodger (Google), 2013-01-09 17:14:53]

lgtm

[commit-bot: I haz the power, 2013-01-09 18:33:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wxjg68@motorola.com/11746027/5001

[commit-bot: I haz the power, 2013-01-09 20:58:29]

Change committed as 175883