Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 11745030: ARM: generate integer zero in a uniform manner. (Closed)

Created:
7 years, 11 months ago by JF
Modified:
7 years, 11 months ago
Reviewers:
ulan
CC:
v8-dev
Visibility:
Public.

Description

ARM: generate integer zero in a uniform manner. ARM generated integer zero as either Operand(0, RelocInfo::NONE32), or Operand(0), or Operand::Zero(). My change makes it use only Operand::Zero(). This has no functional impact, it's pure cleanup. R= ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13318

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -174 lines) Patch
M src/arm/builtins-arm.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 36 chunks +43 lines, -43 lines 0 comments Download
M src/arm/debug-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/deoptimizer-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 47 chunks +63 lines, -61 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 19 chunks +20 lines, -20 lines 0 comments Download
M src/arm/regexp-macro-assembler-arm.cc View 12 chunks +12 lines, -12 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
JF
7 years, 11 months ago (2013-01-04 18:57:13 UTC) #1
ulan
7 years, 11 months ago (2013-01-07 09:30:14 UTC) #2
LGTM. Thanks for cleaning this up. I will land it for you.

Powered by Google App Engine
This is Rietveld 408576698