BinaryValue support for NULL buffer.

BinaryValue support for NULL buffer.

* Apply original change from CL 10389088 (https://chromiumcodereview.appspot.com/10389088)

* Change BinaryValue to use "scoped_ptr<char[]>" instead of "scoped_ptr<char>". By contract, the memory owned should be deleted with the "delete[]" operator.

BUG=127630
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175482

[rpaquay, 2013-01-03 18:27:57]

This change contains the original fix from
https://chromiumcodereview.appspot.com/10389088, in addition to a simple fix to
use "scoped_array" instead of "scoped_ptr" to ensure the right "delete" operator
is called on destruction.

[brettw, 2013-01-03 22:01:23]

lgtm

https://chromiumcodereview.appspot.com/11745016/diff/1/base/values.cc
File base/values.cc (right):

https://chromiumcodereview.appspot.com/11745016/diff/1/base/values.cc#newcode317
base/values.cc:317: buffer_(buffer.release()),
Can you use .Pass() here instead?

[asargent_no_longer_on_chrome, 2013-01-03 22:20:43]

LGTM

[rpaquay, 2013-01-03 23:20:02]

* Address code review feedback from Brett.

* Also, when looking at scoped_ptr.h, there was mention that "scoped_array<T>"
is deprecated and "scope_ptr<T[]>" should be used instead. I updated the CL
accordingly.

https://codereview.chromium.org/11745016/diff/1/base/values.cc
File base/values.cc (right):

https://codereview.chromium.org/11745016/diff/1/base/values.cc#newcode317
base/values.cc:317: buffer_(buffer.release()),
On 2013/01/03 22:01:23, brettw wrote:
> Can you use .Pass() here instead?

Done.

[commit-bot: I haz the power, 2013-01-04 18:14:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11745016/6001

[commit-bot: I haz the power, 2013-01-04 18:46:29]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-07 18:42:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11745016/6001

[commit-bot: I haz the power, 2013-01-07 19:22:06]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-07 22:53:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rpaquay@chromium.org/11745016/18001

[commit-bot: I haz the power, 2013-01-08 03:16:32]

Change committed as 175482