Added TapSuppressionController params to gesture configurations

Added TapSuppressionController params to gesture configurations

Added TapSuppressionController parameters to GestureConfiguration and
used them in TSC.
Removed command line options for configuring TSC, because now they can
be configured through UI.
Added the ability to configure integer parameters through UI, since TSC
parameters are integers.

BUG=162031
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175823

[mohsen, 2013-01-03 15:20:28]

I have added TSC parameters to GestureConfiguration. I will set these parameters
to appropriate values for unit tests in another CL.

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
File chrome/browser/ui/webui/gesture_config_ui.cc (right):

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
chrome/browser/ui/webui/gesture_config_ui.cc:110: 
The following part is to add the ability to set integer preference values
through UI.

https://codereview.chromium.org/11745006/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/tap_suppression_controller_aura.cc (right):

https://codereview.chromium.org/11745006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/tap_suppression_controller_aura.cc:19: const char
switchKey[]) {
The following change is to compute the parameter value every time. Previously,
the value was computed only the first time. But, now the value can be different
each time.

https://codereview.chromium.org/11745006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/tap_suppression_controller_aura.cc:21:
CommandLine* command_line = CommandLine::ForCurrentProcess();
Currently the values can be set in command line, too. Maybe, now that the values
are configurable through GestureConfiguration, we should remove the command line
option completely? (in this CL or a separate one?)

[rjkroege, 2013-01-03 22:42:49]

looking reasonable. can you clean up the command line setting code?

https://codereview.chromium.org/11745006/diff/1/chrome/browser/resources/gest...
File chrome/browser/resources/gesture_config.js (right):

https://codereview.chromium.org/11745006/diff/1/chrome/browser/resources/gest...
chrome/browser/resources/gesture_config.js:135: key:
'fling_max_cancel_to_down_time_in_ms',
all the remaining params are in seconds yes? shouldn't this one be too?

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
File chrome/browser/ui/webui/gesture_config_ui.cc (right):

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
chrome/browser/ui/webui/gesture_config_ui.cc:115:
prefs->SetInteger(pref_name.c_str(), static_cast<int>(value));
the type conversion would happen implicitly? Is the default rounding value what
is desired?

https://codereview.chromium.org/11745006/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/tap_suppression_controller_aura.cc (right):

https://codereview.chromium.org/11745006/diff/1/content/browser/renderer_host...
content/browser/renderer_host/tap_suppression_controller_aura.cc:21:
CommandLine* command_line = CommandLine::ForCurrentProcess();
On 2013/01/03 15:20:28, mohsen wrote:
> Currently the values can be set in command line, too. Maybe, now that the
values
> are configurable through GestureConfiguration, we should remove the command
line
> option completely? (in this CL or a separate one?)

remove in this CL -- which admits some simplification here.

[mohsen, 2013-01-04 16:14:22]

https://codereview.chromium.org/11745006/diff/1/chrome/browser/resources/gest...
File chrome/browser/resources/gesture_config.js (right):

https://codereview.chromium.org/11745006/diff/1/chrome/browser/resources/gest...
chrome/browser/resources/gesture_config.js:135: key:
'fling_max_cancel_to_down_time_in_ms',
On 2013/01/03 22:42:49, rjkroege wrote:
> all the remaining params are in seconds yes? shouldn't this one be too?

Yes, I had noticed that point. I used ms to keep the values as integers and
avoid double/int conversions. Also, I thought that the values will almost always
be small fractions of seconds, e.g. for tests we may set them to values like
.005 or 0.01 seconds which does not seem nice to me! But, I agree that having
them in seconds is more consistent with the rest of the params. What's your
opinion?

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
File chrome/browser/ui/webui/gesture_config_ui.cc (right):

https://codereview.chromium.org/11745006/diff/1/chrome/browser/ui/webui/gestu...
chrome/browser/ui/webui/gesture_config_ui.cc:115:
prefs->SetInteger(pref_name.c_str(), static_cast<int>(value));
On 2013/01/03 22:42:49, rjkroege wrote:
> the type conversion would happen implicitly? Is the default rounding value
what
> is desired?

The main reason is that I wrote this code similar to what we have in
ResetPreferenceValue() above. Also, I think this is more explicit and shows that
we are converting double to int deliberately. A better option in my opinion is
to use args->GetInteger() for TYPE_INTEGER case and avoid conversions between
double and int at all.

[mohsen, 2013-01-04 16:47:58]

I have removed command line parameters. Please take a look.

[rjkroege, 2013-01-07 17:37:34]

lgtm

[mohsen, 2013-01-08 16:35:15]

Please take a look:

sky@ for OWNERS in:
  chrome/browser/ui/gesture_prefs_observer_factory_aura.cc

jhawkins@ for OWNERS in:
  chrome/browser/resources/gesture_config.js
  chrome/browser/ui/webui/gesture_config_ui.cc

nkostylev@ for OWNERS in:
  chrome/browser/chromeos/login/login_utils.cc

joi@ for OWNERS in:
  content/public/common/content_switches.h
  content/public/common/content_switches.cc

[Jói, 2013-01-08 17:18:01]

LGTM for content/public/common.

[James Hawkins, 2013-01-08 18:30:24]

resources & web_ui LGTM

[sky, 2013-01-08 19:12:32]

LGTM

[Nikita (slow), 2013-01-09 14:34:35]

lgtm

[commit-bot: I haz the power, 2013-01-09 15:03:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mohsen@chromium.org/11745006/7001

[commit-bot: I haz the power, 2013-01-09 17:42:15]

Change committed as 175823