Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 11744035: Rename ancient NetworkTransaction tests (Closed)

Created:
7 years, 11 months ago by mmenke
Modified:
7 years, 11 months ago
Reviewers:
gavinp
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Rename ancient NetworkTransaction tests to accurately reflect the number of junk characters they contained. It's unclear if the test names or what they test should be changed, though it likely doesn't matter. This inconsistency has existed since initial.commit, supporting this belief. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175193

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/http/http_network_transaction_spdy2_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mmenke
Inspired by your massive cleanup efforts, here's one of my own. Don't ask why I'm ...
7 years, 11 months ago (2013-01-04 16:51:32 UTC) #1
mmenke
By the way...Sent this to you because: 1) You've sent me similar things. 2) There ...
7 years, 11 months ago (2013-01-04 16:53:02 UTC) #2
gavinp
There are definitely three bytes of junk there. LGTM.
7 years, 11 months ago (2013-01-04 16:53:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/11744035/1
7 years, 11 months ago (2013-01-04 16:54:05 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) browser_tests
7 years, 11 months ago (2013-01-04 19:40:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/11744035/1
7 years, 11 months ago (2013-01-04 19:40:45 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-04 21:06:37 UTC) #7
Message was sent while issue was closed.
Change committed as 175193

Powered by Google App Engine
This is Rietveld 408576698