Add guard to OpenSLESOutputStream::FillBufferQueue() to respect shutdown conditions.

Add guard to OpenSLESOutputStream::FillBufferQueue() to respect shutdown conditions.

There's a race condition between the audio shutdown process and calls to OnMoreData() (in FillBufferQueue()).  During shutdown, or after an error occurs within AudioOutputController, OnMoreData() can return 0 to indicate "no data."  In this case, FillBufferQueue() should not attempt to call simple_buffer_queue_->Enqueue() with a "zero bytes" argument, which is an invalid argument value.

Also changed a DLOG(FATAL) to DLOG(ERROR), per Chromium style guidelines, since there is code that explicitly handles the event after the log statement.

BUG=168260
TEST=build/android/run_tests.py -s media_unittests -f *PlayStateChangeClose*
TBR=tommi@chromium.org


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175107

[miu, 2013-01-03 23:38:17]

Fix for flaky AudioOutputController tests on Android platforms.  PTAL.

Thanks,
Yuri

[Ted C, 2013-01-03 23:39:50]

lgtm

[Ted C, 2013-01-04 00:04:26]

On 2013/01/03 23:39:50, Ted C wrote:
> lgtm

I patched in this change and ran the flaky tests 10 times without issue (it
crashed pretty regularly for me w/o this change)
build/android/run_tests.py -s media_unittests -f *PlayStateChangeClose*

[commit-bot: I haz the power, 2013-01-04 00:07:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/11744026/1

[miu, 2013-01-04 00:09:25]

tommi: FYI--Submitted with you as TBR since the bug was causing Android test
flakiness in the builds.

[commit-bot: I haz the power, 2013-01-04 03:31:57]

Retried try job too often on mac_rel for step(s) browser_tests

[commit-bot: I haz the power, 2013-01-04 04:06:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/miu@chromium.org/11744026/1

[commit-bot: I haz the power, 2013-01-04 05:19:17]

Change committed as 175107