Issue 11744010: [NaCl SDK] Change the kernel_wrap OS #ifdefs in nacl_mounts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11744010: [NaCl SDK] Change the kernel_wrap OS #ifdefs in nacl_mounts. (Closed)

Created:
7 years, 11 months ago by binji

Modified:
7 years, 11 months ago

Reviewers:
noelallen1

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[NaCl SDK] Change the kernel_wrap OS #ifdefs in nacl_mounts. This change allows you to compile all .cc files for nacl-mounts. Previously you need to include compile kernel_wrap.cc, but only copy (not compile) the other kernel_wrap_*.cc files. This is convenient for someone making a visual studio project -- they can just drop all the .cc files into a project and everything "just works". BUG=none R=noelallen@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175665

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -18 lines)			Patch
M	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_glibc.cc	View	3 chunks	+9 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_newlib.cc	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/kernel_wrap_win.cc	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	native_client_sdk/src/libraries/nacl_mounts/library.dsc	View	2 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/11744010/1

7 years, 11 months ago (2013-01-09 00:04:09 UTC) #4

Message was sent while issue was closed.

Change committed as 175665

Expand Messages | Collapse Messages