Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 11744009: Fix AudioPipeReader to handle EOF properly. (Closed)

Created:
7 years, 11 months ago by Sergey Ulanov
Modified:
7 years, 11 months ago
Reviewers:
Lambros
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix AudioPipeReader to handle EOF properly. PulseAudio is started on demand. When PulseAudio is not started read() alaways returns 0 (i.e. EOF). Normally pulseaudio is started on demand by libpulse so that it can be restarted after it's stoped or crashed. Previously AudioPipeReader::DoCapture() didn't handle properly the case when read() returns 0, which would cause it to get into indefinite loop when pulseaudio is not started. BUG=167801 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174913

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M remoting/host/linux/audio_pipe_reader.cc View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
7 years, 11 months ago (2013-01-02 22:18:29 UTC) #1
Lambros
lgtm https://codereview.chromium.org/11744009/diff/1/remoting/host/linux/audio_pipe_reader.cc File remoting/host/linux/audio_pipe_reader.cc (right): https://codereview.chromium.org/11744009/diff/1/remoting/host/linux/audio_pipe_reader.cc#newcode152 remoting/host/linux/audio_pipe_reader.cc:152: PLOG(ERROR) << "read"; optional: PLOG_IF(ERROR, condition) <<..
7 years, 11 months ago (2013-01-02 22:51:28 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/11744009/diff/1/remoting/host/linux/audio_pipe_reader.cc File remoting/host/linux/audio_pipe_reader.cc (right): https://codereview.chromium.org/11744009/diff/1/remoting/host/linux/audio_pipe_reader.cc#newcode152 remoting/host/linux/audio_pipe_reader.cc:152: PLOG(ERROR) << "read"; On 2013/01/02 22:51:28, Lambros wrote: > ...
7 years, 11 months ago (2013-01-02 23:02:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/11744009/1
7 years, 11 months ago (2013-01-02 23:10:11 UTC) #4
commit-bot: I haz the power
7 years, 11 months ago (2013-01-03 02:11:23 UTC) #5
Message was sent while issue was closed.
Change committed as 174913

Powered by Google App Engine
This is Rietveld 408576698