Issue 11743036: requestAutocomplete: change comboboxes to dropdown menus

Issue 11743036: requestAutocomplete: change comboboxes to dropdown menus (Closed)

Created:
7 years, 11 months ago by Evan Stade

Modified:
7 years, 11 months ago

Reviewers:
Ilya Sherman, sky

CC:
chromium-reviews, Raman Kakilate, tfarina, benquan, dhollowa+watch_chromium.org, ahutter, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

requestAutocomplete: change comboboxes to dropdown menus Change comboboxes to dropdown menus, per the latest mocks. Allow users to switch between manual entry and pre-fill modes. lots of TODOs, but this seems like a good stopping point. BUG=157270, 157273 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175439

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : fin #

Patch Set 4 : self review #

Total comments: 4

Patch Set 5 : isherman review #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+252 lines, -247 lines)			Patch
M	chrome/browser/ui/autofill/autofill_dialog_comboboxes.h	View	1 2	1 chunk	+0 lines, -77 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_comboboxes.cc	View	1 2	1 chunk	+0 lines, -70 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller.h	View	1 2 3 4	7 chunks	+22 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_controller.cc	View	1 2 3 4	8 chunks	+67 lines, -18 lines	0 comments	Download
A +	chrome/browser/ui/autofill/autofill_dialog_models.h	View	1 2 3 4	4 chunks	+37 lines, -13 lines	0 comments	Download
A +	chrome/browser/ui/autofill/autofill_dialog_models.cc	View	1 2 3 4	2 chunks	+30 lines, -10 lines	0 comments	Download
M	chrome/browser/ui/autofill/autofill_dialog_view.h	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.h	View	1 2 3 4	7 chunks	+20 lines, -8 lines	0 comments	Download
M	chrome/browser/ui/views/autofill/autofill_dialog_views.cc	View	1 2	8 chunks	+74 lines, -36 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View	1 2 3 4	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ilya Sherman

lgtm https://chromiumcodereview.appspot.com/11743036/diff/7001/chrome/browser/ui/autofill/autofill_dialog_models.h File chrome/browser/ui/autofill/autofill_dialog_models.h (right): https://chromiumcodereview.appspot.com/11743036/diff/7001/chrome/browser/ui/autofill/autofill_dialog_models.h#newcode26 chrome/browser/ui/autofill/autofill_dialog_models.h:26: const std::string& key) = 0; nit: Do you ...

7 years, 11 months ago (2013-01-07 20:56:02 UTC) #3

Evan Stade

https://chromiumcodereview.appspot.com/11743036/diff/7001/chrome/browser/ui/autofill/autofill_dialog_models.h File chrome/browser/ui/autofill/autofill_dialog_models.h (right): https://chromiumcodereview.appspot.com/11743036/diff/7001/chrome/browser/ui/autofill/autofill_dialog_models.h#newcode26 chrome/browser/ui/autofill/autofill_dialog_models.h:26: const std::string& key) = 0; On 2013/01/07 20:56:02, Ilya ...

7 years, 11 months ago (2013-01-07 21:38:14 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/11743036/15001

7 years, 11 months ago (2013-01-07 21:40:23 UTC) #5

Message was sent while issue was closed.

Change committed as 175439

Expand Messages | Collapse Messages