Implemented BluetoothExtensionFunction.

Implemented BluetoothExtensionFunction.

From discussion with Bryan (@bryeung) and Scott (@keybuk), we decided to make
the bluetooth extension functions asynchronous because it takes time to
initialize BluetoothAdapter. So I implemented BluetoothExtensionFunction, which
is the base class for all the subclasses and it calls DoWork() when the
bluetooth adapter is ready to use.

After this CL is submitted, I will turn
BluetoothAdapterFactory::DefaultAdapter() to receive a callback and run the
callback when the bluetooth adapter is ready.

TBR=sky@chromium.org
BUG=135470
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175553

[youngki, 2013-01-03 20:59:49]

Hi Antony, could you review this CL? Mike (@miket) is away on vacation and I am
wondering if you could review this CL; I have implemented
BluetoothExtensionFunction and made all the bluetooth extension functions
asynchronous. The design has been discussed with Bryan and Scott, both cc'd in
this CL.

Thanks,

[asargent_no_longer_on_chrome, 2013-01-04 17:41:21]

LGTM

https://chromiumcodereview.appspot.com/11743024/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h
(right):

https://chromiumcodereview.appspot.com/11743024/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h:36: //
initialized.
nit: this comment is slightly confusing ; do you mean something like

"Implemented by individual bluetooth extension functions, called automatically
once |adpater| has been initialized."

?

[youngki, 2013-01-04 18:19:09]

Thanks for the quick review Antony. I am putting this into commit queue then
submit.

https://chromiumcodereview.appspot.com/11743024/diff/1/chrome/browser/extensi...
File chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h
(right):

https://chromiumcodereview.appspot.com/11743024/diff/1/chrome/browser/extensi...
chrome/browser/extensions/api/bluetooth/bluetooth_extension_function.h:36: //
initialized.
On 2013/01/04 17:41:21, Antony Sargent wrote:
> nit: this comment is slightly confusing ; do you mean something like
> 
> "Implemented by individual bluetooth extension functions, called automatically
> once |adpater| has been initialized."
> 
> ?

Done.

[youngki, 2013-01-04 19:11:59]

I had to replace some of EXTENSION_FUNCTION_VALIDATE macro with the if block
that returns nothing because DoWork() is void function.

[asargent_no_longer_on_chrome, 2013-01-04 21:54:22]

https://chromiumcodereview.appspot.com/11743024/diff/4002/chrome/browser/exte...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://chromiumcodereview.appspot.com/11743024/diff/4002/chrome/browser/exte...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:171: }
Instead of manually putting in the code to essentially duplicate
EXTENSION_FUNCTION_VALIDATE, maybe it would be simpler to just change the
signature of DoWork to return a boolean?

[youngki, 2013-01-04 23:44:44]

https://chromiumcodereview.appspot.com/11743024/diff/4002/chrome/browser/exte...
File chrome/browser/extensions/api/bluetooth/bluetooth_api.cc (right):

https://chromiumcodereview.appspot.com/11743024/diff/4002/chrome/browser/exte...
chrome/browser/extensions/api/bluetooth/bluetooth_api.cc:171: }
On 2013/01/04 21:54:22, Antony Sargent wrote:
> Instead of manually putting in the code to essentially duplicate
> EXTENSION_FUNCTION_VALIDATE, maybe it would be simpler to just change the
> signature of DoWork to return a boolean?
> 
> 

Done.

[asargent_no_longer_on_chrome, 2013-01-04 23:53:35]

Cool, LGTM again

[commit-bot: I haz the power, 2013-01-05 04:47:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/25001

[commit-bot: I haz the power, 2013-01-05 04:47:32]

Presubmit check for 11743024-25001 failed and returned exit status 1.


Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 3.0s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[youngki, 2013-01-06 15:08:25]

Adding TBR=sky@chromium.org for gyp change (adding
bluetooth_extension_function.{h|cc})

[commit-bot: I haz the power, 2013-01-06 15:08:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/25001

[commit-bot: I haz the power, 2013-01-06 15:29:26]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-06 20:12:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/25001

[commit-bot: I haz the power, 2013-01-06 20:24:08]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 14:20:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/38003

[commit-bot: I haz the power, 2013-01-07 14:33:43]

Retried try job too often on ios_dbg_simulator for step(s) sync_unit_tests,
unit_tests

[commit-bot: I haz the power, 2013-01-07 15:37:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/38003

[commit-bot: I haz the power, 2013-01-07 17:14:47]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-07 18:55:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/38003

[commit-bot: I haz the power, 2013-01-07 21:16:36]

Retried try job too often on win_aura for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2013-01-08 01:01:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/38003

[commit-bot: I haz the power, 2013-01-08 18:11:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/youngki@chromium.org/11743024/38003

[commit-bot: I haz the power, 2013-01-08 18:11:34]

Change committed as 175553