Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1321)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java

Issue 11743011: Add history popup when long pressing on the back key. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use a padding drawable for null favicons to avoid jumping UI. Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java b/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java
index a2896efefb23f89adacd93f5eff87c3cb8c268d7..6498e09f8b0dd44182f8737f5b2eabd7c23ea9a4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java
+++ b/content/public/android/java/src/org/chromium/content/browser/NavigationEntry.java
@@ -11,17 +11,19 @@ import android.graphics.Bitmap;
*/
public class NavigationEntry {
- private String mUrl;
- private String mOriginalUrl;
- private String mVirtualUrl;
- private String mTitle;
+ private final int mIndex;
+ private final String mUrl;
+ private final String mOriginalUrl;
+ private final String mVirtualUrl;
+ private final String mTitle;
private Bitmap mFavicon;
/**
* Default constructor.
*/
- /* package */ NavigationEntry(String url, String virtualUrl, String originalUrl, String title,
- Bitmap favicon) {
+ protected NavigationEntry(int index, String url, String virtualUrl, String originalUrl,
+ String title, Bitmap favicon) {
+ mIndex = index;
mUrl = url;
mVirtualUrl = virtualUrl;
mOriginalUrl = originalUrl;
@@ -30,6 +32,13 @@ public class NavigationEntry {
}
/**
+ * @return The index into the navigation history that this entry represents.
+ */
+ public int getIndex() {
+ return mIndex;
+ }
+
+ /**
* @return The actual URL of the page. For some about pages, this may be a
* scary data: URL or something like that. Use GetVirtualURL() for
* showing to the user.
@@ -77,4 +86,10 @@ public class NavigationEntry {
return mFavicon;
}
+ /**
+ * @param favicon The updated favicon to replace the existing one with.
+ */
+ public void updateFavicon(Bitmap favicon) {
+ mFavicon = favicon;
+ }
}

Powered by Google App Engine
This is Rietveld 408576698