chrome/browser/browsing_data/browsing_data_remover.cc - Issue 11742037: Make ServerBoundCertStore interface async, move SQLiteServerBoundCertStore load onto DB thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover.cc

Issue 11742037: Make ServerBoundCertStore interface async, move SQLiteServerBoundCertStore load onto DB thread. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix login_utils_browsertest Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/browsing_data/browsing_data_remover.h ('k') | chrome/browser/browsing_data/browsing_data_remover_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/browsing_data/browsing_data_remover.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover.cc b/chrome/browser/browsing_data/browsing_data_remover.cc

index d55c7bc533a8ede2aa84d84fcf55610f9adea8fe..0476799aefb1d037cdeda2407fa57d7f2bdf564f 100644

--- a/chrome/browser/browsing_data/browsing_data_remover.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover.cc

@@ -991,7 +991,13 @@ void BrowsingDataRemover::ClearServerBoundCertsOnIOThread(

net::ServerBoundCertService* server_bound_cert_service =

rq_context->GetURLRequestContext()->server_bound_cert_service();

server_bound_cert_service->GetCertStore()->DeleteAllCreatedBetween(

- delete_begin_, delete_end_);

+ delete_begin_, delete_end_,

+ base::Bind(&BrowsingDataRemover::OnClearedServerBoundCertsOnIOThread,

+ base::Unretained(this), base::Unretained(rq_context)));

+void BrowsingDataRemover::OnClearedServerBoundCertsOnIOThread(

+ net::URLRequestContextGetter* rq_context) {

// Need to close open SSL connections which may be using the channel ids we

// are deleting.

// TODO(mattm): http://crbug.com/166069 Make the server bound cert