Make ServerBoundCertStore interface async, move SQLiteServerBoundCertStore load onto DB thread.

chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/browsing_data/browsing_data_server_bound_cert_helper.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/message_loop.h"
@@ skipping 13 matching lines @@
   // BrowsingDataServerBoundCertHelper methods.
   virtual void StartFetching(const FetchResultCallback& callback) OVERRIDE;
   virtual void DeleteServerBoundCert(const std::string& server_id) OVERRIDE;
 
  private:
   virtual ~BrowsingDataServerBoundCertHelperImpl();
 
   // Fetch the certs. This must be called in the IO thread.
   void FetchOnIOThread();
 
+  void OnFetchComplete(
+      const net::ServerBoundCertStore::ServerBoundCertList& cert_list);
+
   // Notifies the completion callback. This must be called in the UI thread.
-  void NotifyInUIThread();
+  void NotifyInUIThread(
+      const net::ServerBoundCertStore::ServerBoundCertList& cert_list);
 
   // Delete a single cert. This must be called in IO thread.
   void DeleteOnIOThread(const std::string& server_id);
 
-  // Access to |server_bound_cert_list_| is triggered indirectly via the UI
-  // thread and guarded by |is_fetching_|. This means |server_bound_cert_list_|
-  // is only accessed while |is_fetching_| is true. The flag |is_fetching_| is
-  // only accessed on the UI thread.
-  net::ServerBoundCertStore::ServerBoundCertList server_bound_cert_list_;
+  // Called when deletion is done.
+  void DeleteCallback();
 
   // Indicates whether or not we're currently fetching information:
   // it's true when StartFetching() is called in the UI thread, and it's reset
   // after we notify the callback in the UI thread.
   // This only mutates on the UI thread.
   bool is_fetching_;
 
   scoped_refptr<net::URLRequestContextGetter> request_context_getter_;
 
   // This only mutates on the UI thread.
@@ skipping 35 matching lines @@
       base::Bind(&BrowsingDataServerBoundCertHelperImpl::DeleteOnIOThread,
                  this, server_id));
 }
 
 void BrowsingDataServerBoundCertHelperImpl::FetchOnIOThread() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
   net::ServerBoundCertStore* cert_store =
       request_context_getter_->GetURLRequestContext()->
       server_bound_cert_service()->GetCertStore();
   if (cert_store) {
-    server_bound_cert_list_.clear();
-    cert_store->GetAllServerBoundCerts(&server_bound_cert_list_);
-    content::BrowserThread::PostTask(
-        content::BrowserThread::UI, FROM_HERE,
-        base::Bind(&BrowsingDataServerBoundCertHelperImpl::NotifyInUIThread,
-                   this));
+    cert_store->GetAllServerBoundCerts(base::Bind(
+        &BrowsingDataServerBoundCertHelperImpl::OnFetchComplete, this));
+  } else {
+    OnFetchComplete(net::ServerBoundCertStore::ServerBoundCertList());
   }
 }
 
-void BrowsingDataServerBoundCertHelperImpl::NotifyInUIThread() {
+void BrowsingDataServerBoundCertHelperImpl::OnFetchComplete(
+    const net::ServerBoundCertStore::ServerBoundCertList& cert_list) {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  content::BrowserThread::PostTask(
+      content::BrowserThread::UI, FROM_HERE,
+      base::Bind(&BrowsingDataServerBoundCertHelperImpl::NotifyInUIThread,
+                 this, cert_list));
+}
+
+void BrowsingDataServerBoundCertHelperImpl::NotifyInUIThread(
+    const net::ServerBoundCertStore::ServerBoundCertList& cert_list) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   DCHECK(is_fetching_);
   is_fetching_ = false;
-  completion_callback_.Run(server_bound_cert_list_);
+  completion_callback_.Run(cert_list);
   completion_callback_.Reset();
 }
 
 void BrowsingDataServerBoundCertHelperImpl::DeleteOnIOThread(
     const std::string& server_id) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
   net::ServerBoundCertStore* cert_store =
       request_context_getter_->GetURLRequestContext()->
       server_bound_cert_service()->GetCertStore();
   if (cert_store) {
-    cert_store->DeleteServerBoundCert(server_id);
-    // Need to close open SSL connections which may be using the channel ids we
-    // are deleting.
-    // TODO(mattm): http://crbug.com/166069 Make the server bound cert
-    // service/store have observers that can notify relevant things directly.
-    request_context_getter_->GetURLRequestContext()->ssl_config_service()->
-        NotifySSLConfigChange();
+    cert_store->DeleteServerBoundCert(
+        server_id,
+        base::Bind(&BrowsingDataServerBoundCertHelperImpl::DeleteCallback,
+                   this));
   }
 }
 
+void BrowsingDataServerBoundCertHelperImpl::DeleteCallback() {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  // Need to close open SSL connections which may be using the channel ids we
+  // are deleting.
+  // TODO(mattm): http://crbug.com/166069 Make the server bound cert
+  // service/store have observers that can notify relevant things directly.
+  request_context_getter_->GetURLRequestContext()->ssl_config_service()->
+      NotifySSLConfigChange();
+}
+
 }  // namespace
 
 // static
 BrowsingDataServerBoundCertHelper*
 BrowsingDataServerBoundCertHelper::Create(Profile* profile) {
   return new BrowsingDataServerBoundCertHelperImpl(profile);
 }
 
 CannedBrowsingDataServerBoundCertHelper::
 CannedBrowsingDataServerBoundCertHelper() {}
@@ skipping 50 matching lines @@
   for (ServerBoundCertMap::iterator i = server_bound_cert_map_.begin();
        i != server_bound_cert_map_.end(); ++i)
     cert_list.push_back(i->second);
   completion_callback_.Run(cert_list);
 }
 
 void CannedBrowsingDataServerBoundCertHelper::DeleteServerBoundCert(
     const std::string& server_id) {
   NOTREACHED();
 }