Issue 11742032: For git checkouts of depot_tools, update remote.origin.url to the git-on-borg mirror.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11742032: For git checkouts of depot_tools, update remote.origin.url to the git-on-borg mirror. (Closed)

Created:
7 years, 11 months ago by szager1

Modified:
7 years, 11 months ago

Reviewers:
cmp, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools@master

Visibility:
Public.

More Reviews

Description

For git checkouts of depot_tools, update remote.origin.url to the git-on-borg mirror. BUG=168205 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=175040

Patch Set 1 #

Patch Set 2 : Add newline #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	update_depot_tools	View	1	2 chunks	+18 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

szager1

On 2013/01/03 22:54:55, cmp wrote: > lgtm, how did you test this? From linux and ...

7 years, 11 months ago (2013-01-03 23:05:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/11742032/3

7 years, 11 months ago (2013-01-03 23:06:22 UTC) #4

M-A Ruel

7 years, 11 months ago (2013-01-07 16:19:18 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/11742032/diff/3/update_depot_tools
File update_depot_tools (right):

https://codereview.chromium.org/11742032/diff/3/update_depot_tools#newcode25
update_depot_tools:25:
CANONICAL_GIT_URL="https://chromium.googlesource.com/chromium/tools/depot_tools"
Wouldn't it be better to use ".../depot_tools.git" for consistency.

I kinda dislike that we support different urls and would highly prefer to
support *only one exact* url. It's a pain to manage afterward, like in the CQ,
because there's a lot of possible permutations. :(

Expand Messages | Collapse Messages