Allow Plugin placeholders to be shown when plugins are disabled.

Allow Plugin placeholders to be shown when plugins are disabled.

BUG=167971, 162667
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175042

[Bernhard Bauer, 2013-01-03 06:51:37]

lgtm

https://codereview.chromium.org/11742017/diff/2001/chrome/renderer/chrome_con...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/11742017/diff/2001/chrome/renderer/chrome_con...
chrome/renderer/chrome_content_renderer_client.cc:368: output.status.value =
ChromeViewHostMsg_GetPluginInfo_Status::kNotFound;
Not: I think it would probably not be unreasonable to make kNotFound the default
value in the struct, then you wouldn't need the #else.

[jam, 2013-01-03 07:06:36]

lgtm

[nilesh, 2013-01-03 19:37:59]

https://codereview.chromium.org/11742017/diff/2001/chrome/renderer/chrome_con...
File chrome/renderer/chrome_content_renderer_client.cc (right):

https://codereview.chromium.org/11742017/diff/2001/chrome/renderer/chrome_con...
chrome/renderer/chrome_content_renderer_client.cc:368: output.status.value =
ChromeViewHostMsg_GetPluginInfo_Status::kNotFound;
On 2013/01/03 06:51:37, Bernhard Bauer wrote:
> Not: I think it would probably not be unreasonable to make kNotFound the
default
> value in the struct, then you wouldn't need the #else.

It looks like there is code which relies on the default value to be kAllowed
(e.g. PluginInfoMessageFilter::Context::FindEnabledPlugin).

[commit-bot: I haz the power, 2013-01-03 21:16:53]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nileshagrawal@chromium.org/11742017/2001

[commit-bot: I haz the power, 2013-01-03 23:16:45]

Change committed as 175042