Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 11742007: Add support for adding 256x256 pngs to Windows .ico files. (Closed)

Created:
7 years, 11 months ago by Alexei Svitkine (slow)
Modified:
7 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Add support for adding 256x256 pngs to Windows .ico files. These are needed to support the "large icon" view under Vista+. BUG=167277, 163864, 110379 TEST=New unit test. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175567

Patch Set 1 : #

Total comments: 6

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -44 lines) Patch
M chrome/browser/jumplist_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_shortcut_manager_win.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/icon_util.h View 1 3 chunks +12 lines, -6 lines 0 comments Download
M ui/gfx/icon_util.cc View 1 4 chunks +44 lines, -10 lines 0 comments Download
M ui/gfx/icon_util_unittest.cc View 1 7 chunks +64 lines, -25 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Alexei Svitkine (slow)
Hey Scott, Could you review this? Unfortunately there doesn't seem to be a better owner ...
7 years, 11 months ago (2013-01-02 22:27:28 UTC) #1
Alexei Svitkine (slow)
Ping! Let me know if you have a better reviewer in mind for this. (I ...
7 years, 11 months ago (2013-01-07 16:45:26 UTC) #2
sky
https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc File ui/gfx/icon_util.cc (right): https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc#newcode300 ui/gfx/icon_util.cc:300: CHECK_EQ(256, large_bitmap.width()); Why CHECK and not DCHECK? https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc#newcode317 ui/gfx/icon_util.cc:317: ...
7 years, 11 months ago (2013-01-07 17:05:24 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc File ui/gfx/icon_util.cc (right): https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc#newcode300 ui/gfx/icon_util.cc:300: CHECK_EQ(256, large_bitmap.width()); On 2013/01/07 17:05:24, sky wrote: > Why ...
7 years, 11 months ago (2013-01-07 17:51:28 UTC) #4
sky
https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc File ui/gfx/icon_util.cc (right): https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc#newcode300 ui/gfx/icon_util.cc:300: CHECK_EQ(256, large_bitmap.width()); On 2013/01/07 17:51:28, Alexei Svitkine wrote: > ...
7 years, 11 months ago (2013-01-07 22:18:56 UTC) #5
Alexei Svitkine (slow)
https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc File ui/gfx/icon_util.cc (right): https://codereview.chromium.org/11742007/diff/1010/ui/gfx/icon_util.cc#newcode300 ui/gfx/icon_util.cc:300: CHECK_EQ(256, large_bitmap.width()); On 2013/01/07 22:18:56, sky wrote: > On ...
7 years, 11 months ago (2013-01-07 22:25:22 UTC) #6
sky
LGTM
7 years, 11 months ago (2013-01-08 01:15:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11742007/32001
7 years, 11 months ago (2013-01-08 01:39:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/11742007/32001
7 years, 11 months ago (2013-01-08 16:08:39 UTC) #9
commit-bot: I haz the power
7 years, 11 months ago (2013-01-08 19:03:00 UTC) #10
Message was sent while issue was closed.
Change committed as 175567

Powered by Google App Engine
This is Rietveld 408576698