Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 11741036: Adding a call to clear text composition on tap. (Closed)

Created:
7 years, 11 months ago by aurimas (slooooooooow)
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Adding a call to clear text composition on tap. Adding a call to clear text composition on tap gestures and also changing the places where the text updates get sent back to the browser. BUG=167127 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175712

Patch Set 1 #

Patch Set 2 : Adding GestureLongPress check #

Patch Set 3 : change java method name to restartInput #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -14 lines) Patch
M content/public/android/java/src/org/chromium/content/browser/ImeAdapter.java View 1 2 5 chunks +12 lines, -13 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
aurimas (slooooooooow)
7 years, 11 months ago (2013-01-04 21:21:39 UTC) #1
aurimas (slooooooooow)
+jcivelli for java side changes +jamesr for content/renderer changes UpdateTextInputState call that is removed from ...
7 years, 11 months ago (2013-01-07 19:08:31 UTC) #2
Yusuf
lgtm These changes will make updateTextInputState getting called much less frequently. They will resolve quite ...
7 years, 11 months ago (2013-01-07 19:13:26 UTC) #3
jamesr
lgtm, assuming it was tested in chromeos with threaded compositing enabled
7 years, 11 months ago (2013-01-07 19:19:47 UTC) #4
aurimas (slooooooooow)
+nona to confirm this does not break ChromeOS
7 years, 11 months ago (2013-01-08 16:32:17 UTC) #5
Jay Civelli
lgtm
7 years, 11 months ago (2013-01-08 17:48:37 UTC) #6
Seigo Nonaka
lgtm lgtm, I checked on my Chrome OS device(lumpy) and seems working fine.
7 years, 11 months ago (2013-01-08 23:34:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/11741036/9001
7 years, 11 months ago (2013-01-09 00:03:46 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-09 05:34:51 UTC) #9
Message was sent while issue was closed.
Change committed as 175712

Powered by Google App Engine
This is Rietveld 408576698