Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5974)

Unified Diff: chrome/browser/extensions/extension_service_unittest.cc

Issue 11741035: Exclude hosted apps from post-sideload UI. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: test fix Created 7 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_service_unittest.cc
diff --git a/chrome/browser/extensions/extension_service_unittest.cc b/chrome/browser/extensions/extension_service_unittest.cc
index f809c045722e6f69de140abebfc0e2ad22783a30..8b1d0f18a092e1de12a90078e13159d2b5e666f9 100644
--- a/chrome/browser/extensions/extension_service_unittest.cc
+++ b/chrome/browser/extensions/extension_service_unittest.cc
@@ -5717,14 +5717,12 @@ TEST_F(ExtensionServiceTest, ExternalInstallGlobalError) {
EXPECT_FALSE(extensions::HasExternalInstallError(service_));
// A hosted app, installed externally.
- // This SHOULD trigger an alert.
+ // This should NOT trigger an alert.
provider->UpdateOrAddExtension(hosted_app, "1.0.0.0",
data_dir_.AppendASCII("hosted_app.crx"));
service_->CheckForExternalUpdates();
loop_.RunUntilIdle();
- EXPECT_TRUE(extensions::HasExternalInstallError(service_));
- service_->EnableExtension(hosted_app);
EXPECT_FALSE(extensions::HasExternalInstallError(service_));
// Another normal extension, but installed externally.
« no previous file with comments | « chrome/browser/extensions/extension_service.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698