Issue 11741023: LauncherItemController: Treat TYPE_EXTENSION_PANEL as ash::TYPE_PLATFORM_APP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11741023: LauncherItemController: Treat TYPE_EXTENSION_PANEL as ash::TYPE_PLATFORM_APP (Closed)

Created:
7 years, 11 months ago by stevenjb

Modified:
7 years, 11 months ago

Reviewers:
flackr, sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

LauncherItemController: Treat TYPE_EXTENSION_PANEL as ash::TYPE_PLATFORM_APP As we define new behavior for panels in the launcher (e.g. right aligned icons), we want to treat v1 panels (TYPE_EXTENSION_PANEL) as apps, not panels. BUG=168229 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175449

Patch Set 1 #

Patch Set 2 : Fix unit_tests #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/ash/launcher/browser_launcher_item_controller_unittest.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/ash/launcher/launcher_item_controller.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11741023/1002

7 years, 11 months ago (2013-01-07 22:11:05 UTC) #4

Message was sent while issue was closed.

Change committed as 175449

Expand Messages | Collapse Messages