Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2901)

Unified Diff: chrome/browser/prefs/pref_service_builder.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix double registration in Chrome Frame test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_service_builder.h ('k') | chrome/browser/prefs/pref_service_mock_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service_builder.cc
diff --git a/chrome/browser/prefs/pref_service_builder.cc b/chrome/browser/prefs/pref_service_builder.cc
index c1880b1db657d6515ec89f65c864ce8ff96287c6..ff84b591df792800f6532fef9777b9d463c6b648 100644
--- a/chrome/browser/prefs/pref_service_builder.cc
+++ b/chrome/browser/prefs/pref_service_builder.cc
@@ -9,7 +9,7 @@
#include "base/prefs/json_pref_store.h"
#include "chrome/browser/prefs/pref_notifier_impl.h"
#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/prefs/pref_service_simple.h"
+
#include "chrome/browser/prefs/pref_value_store.h"
namespace {
@@ -72,10 +72,9 @@ PrefServiceBuilder& PrefServiceBuilder::WithAsync(bool async) {
return *this;
}
-PrefServiceSimple* PrefServiceBuilder::CreateSimple() {
- DefaultPrefStore* default_pref_store = new DefaultPrefStore();
+PrefService* PrefServiceBuilder::Create(PrefRegistry* pref_registry) {
PrefNotifierImpl* pref_notifier = new PrefNotifierImpl();
- PrefServiceSimple* pref_service = new PrefServiceSimple(
+ PrefService* pref_service = new PrefService(
pref_notifier,
new PrefValueStore(
managed_prefs_.get(),
@@ -83,10 +82,10 @@ PrefServiceSimple* PrefServiceBuilder::CreateSimple() {
command_line_prefs_.get(),
user_prefs_.get(),
recommended_prefs_.get(),
- default_pref_store,
+ pref_registry->defaults(),
pref_notifier),
user_prefs_.get(),
- default_pref_store,
+ pref_registry,
read_error_callback_,
async_);
ResetDefaultState();
« no previous file with comments | « chrome/browser/prefs/pref_service_builder.h ('k') | chrome/browser/prefs/pref_service_mock_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698