Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/prefs/pref_notifier_impl_unittest.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix double registration in Chrome Frame test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/callback.h" 6 #include "base/callback.h"
7 #include "base/prefs/pref_observer.h" 7 #include "base/prefs/pref_observer.h"
8 #include "chrome/browser/prefs/mock_pref_change_callback.h" 8 #include "chrome/browser/prefs/mock_pref_change_callback.h"
9 #include "chrome/browser/prefs/pref_notifier_impl.h" 9 #include "chrome/browser/prefs/pref_notifier_impl.h"
10 #include "chrome/browser/prefs/pref_registry_simple.h"
10 #include "chrome/browser/prefs/pref_service.h" 11 #include "chrome/browser/prefs/pref_service.h"
11 #include "chrome/browser/prefs/pref_value_store.h" 12 #include "chrome/browser/prefs/pref_value_store.h"
12 #include "chrome/common/chrome_notification_types.h" 13 #include "chrome/common/chrome_notification_types.h"
13 #include "chrome/test/base/testing_pref_service.h" 14 #include "chrome/test/base/testing_pref_service.h"
14 #include "testing/gmock/include/gmock/gmock.h" 15 #include "testing/gmock/include/gmock/gmock.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 17
17 using testing::_; 18 using testing::_;
18 using testing::Field; 19 using testing::Field;
19 using testing::Invoke; 20 using testing::Invoke;
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 const Value* value) { 87 const Value* value) {
87 EXPECT_CALL(*this, OnPreferenceChanged(prefs, pref_name)) 88 EXPECT_CALL(*this, OnPreferenceChanged(prefs, pref_name))
88 .With(PrefValueMatches(prefs, pref_name, value)); 89 .With(PrefValueMatches(prefs, pref_name, value));
89 } 90 }
90 }; 91 };
91 92
92 // Test fixture class. 93 // Test fixture class.
93 class PrefNotifierTest : public testing::Test { 94 class PrefNotifierTest : public testing::Test {
94 protected: 95 protected:
95 virtual void SetUp() { 96 virtual void SetUp() {
96 pref_service_.RegisterBooleanPref(kChangedPref, 97 pref_service_.registry()->RegisterBooleanPref(kChangedPref, true);
97 true); 98 pref_service_.registry()->RegisterBooleanPref(kUnchangedPref, true);
98 pref_service_.RegisterBooleanPref(kUnchangedPref,
99 true);
100 } 99 }
101 100
102 TestingPrefServiceSimple pref_service_; 101 TestingPrefServiceSimple pref_service_;
103 102
104 PrefObserverMock obs1_; 103 PrefObserverMock obs1_;
105 PrefObserverMock obs2_; 104 PrefObserverMock obs2_;
106 }; 105 };
107 106
108 TEST_F(PrefNotifierTest, OnPreferenceChanged) { 107 TEST_F(PrefNotifierTest, OnPreferenceChanged) {
109 MockPrefNotifier notifier(&pref_service_); 108 MockPrefNotifier notifier(&pref_service_);
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
220 EXPECT_CALL(obs2_, OnPreferenceChanged(&pref_service_, kChangedPref)); 219 EXPECT_CALL(obs2_, OnPreferenceChanged(&pref_service_, kChangedPref));
221 notifier.OnPreferenceChanged(kChangedPref); 220 notifier.OnPreferenceChanged(kChangedPref);
222 Mock::VerifyAndClearExpectations(&obs1_); 221 Mock::VerifyAndClearExpectations(&obs1_);
223 Mock::VerifyAndClearExpectations(&obs2_); 222 Mock::VerifyAndClearExpectations(&obs2_);
224 223
225 notifier.RemovePrefObserver(kChangedPref, &obs2_); 224 notifier.RemovePrefObserver(kChangedPref, &obs2_);
226 notifier.RemovePrefObserver(kUnchangedPref, &obs2_); 225 notifier.RemovePrefObserver(kUnchangedPref, &obs2_);
227 } 226 }
228 227
229 } // namespace 228 } // namespace
OLDNEW
« no previous file with comments | « chrome/browser/prefs/chrome_pref_service_factory.cc ('k') | chrome/browser/prefs/pref_registry.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698