Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: chrome/browser/notifications/notification_prefs_manager.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix double registration in Chrome Frame test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/notifications/notification_prefs_manager.h" 5 #include "chrome/browser/notifications/notification_prefs_manager.h"
6 6
7 #include "chrome/browser/prefs/pref_registry_simple.h"
7 #include "chrome/browser/prefs/pref_service.h" 8 #include "chrome/browser/prefs/pref_service.h"
8 #include "chrome/common/pref_names.h" 9 #include "chrome/common/pref_names.h"
9 10
10 // static 11 // static
11 void NotificationPrefsManager::RegisterPrefs(PrefServiceSimple* prefs) { 12 void NotificationPrefsManager::RegisterPrefs(PrefService* prefs,
12 prefs->RegisterIntegerPref(prefs::kDesktopNotificationPosition, 13 PrefRegistrySimple* registry) {
13 BalloonCollection::DEFAULT_POSITION); 14 registry->RegisterIntegerPref(prefs::kDesktopNotificationPosition,
15 BalloonCollection::DEFAULT_POSITION);
14 #if defined(OS_CHROMEOS) 16 #if defined(OS_CHROMEOS)
15 // Option menu for changing desktop notification position on ChromeOS is 17 // Option menu for changing desktop notification position on ChromeOS is
16 // disabled. Force preference to default. 18 // disabled. Force preference to default.
19 //
20 // TODO(joi): This shouldn't be done during registration;
21 // registration should all be done up front, before there even
22 // exists a PrefService.
17 prefs->SetInteger(prefs::kDesktopNotificationPosition, 23 prefs->SetInteger(prefs::kDesktopNotificationPosition,
18 BalloonCollection::DEFAULT_POSITION); 24 BalloonCollection::DEFAULT_POSITION);
19 #endif 25 #endif
20 } 26 }
OLDNEW
« no previous file with comments | « chrome/browser/notifications/notification_prefs_manager.h ('k') | chrome/browser/plugins/plugin_finder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698