Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: chrome/browser/net/http_server_properties_manager_unittest.cc

Issue 11741003: Remove PrefServiceSimple, replacing it with PrefService and PrefRegistrySimple. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix double registration in Chrome Frame test. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/http_server_properties_manager.h" 5 #include "chrome/browser/net/http_server_properties_manager.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/message_loop.h" 8 #include "base/message_loop.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/prefs/pref_registry_simple.h"
10 #include "chrome/common/pref_names.h" 11 #include "chrome/common/pref_names.h"
11 #include "chrome/test/base/testing_pref_service.h" 12 #include "chrome/test/base/testing_pref_service.h"
12 #include "content/public/test/test_browser_thread.h" 13 #include "content/public/test/test_browser_thread.h"
13 #include "googleurl/src/gurl.h" 14 #include "googleurl/src/gurl.h"
14 #include "testing/gmock/include/gmock/gmock.h" 15 #include "testing/gmock/include/gmock/gmock.h"
15 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
16 17
17 namespace chrome_browser_net { 18 namespace chrome_browser_net {
18 19
19 namespace { 20 namespace {
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 }; 78 };
78 79
79 class HttpServerPropertiesManagerTest : public testing::Test { 80 class HttpServerPropertiesManagerTest : public testing::Test {
80 protected: 81 protected:
81 HttpServerPropertiesManagerTest() 82 HttpServerPropertiesManagerTest()
82 : ui_thread_(BrowserThread::UI, &loop_), 83 : ui_thread_(BrowserThread::UI, &loop_),
83 io_thread_(BrowserThread::IO, &loop_) { 84 io_thread_(BrowserThread::IO, &loop_) {
84 } 85 }
85 86
86 virtual void SetUp() OVERRIDE { 87 virtual void SetUp() OVERRIDE {
87 pref_service_.RegisterDictionaryPref(prefs::kHttpServerProperties); 88 pref_service_.registry()->RegisterDictionaryPref(
89 prefs::kHttpServerProperties);
88 http_server_props_manager_.reset( 90 http_server_props_manager_.reset(
89 new StrictMock<TestingHttpServerPropertiesManager>(&pref_service_)); 91 new StrictMock<TestingHttpServerPropertiesManager>(&pref_service_));
90 ExpectCacheUpdate(); 92 ExpectCacheUpdate();
91 loop_.RunUntilIdle(); 93 loop_.RunUntilIdle();
92 } 94 }
93 95
94 virtual void TearDown() OVERRIDE { 96 virtual void TearDown() OVERRIDE {
95 if (http_server_props_manager_.get()) 97 if (http_server_props_manager_.get())
96 http_server_props_manager_->ShutdownOnUIThread(); 98 http_server_props_manager_->ShutdownOnUIThread();
97 loop_.RunUntilIdle(); 99 loop_.RunUntilIdle();
(...skipping 341 matching lines...) Expand 10 before | Expand all | Expand 10 after
439 // Run the task after shutdown, but before deletion. 441 // Run the task after shutdown, but before deletion.
440 loop_.RunUntilIdle(); 442 loop_.RunUntilIdle();
441 Mock::VerifyAndClearExpectations(http_server_props_manager_.get()); 443 Mock::VerifyAndClearExpectations(http_server_props_manager_.get());
442 http_server_props_manager_.reset(); 444 http_server_props_manager_.reset();
443 loop_.RunUntilIdle(); 445 loop_.RunUntilIdle();
444 } 446 }
445 447
446 } // namespace 448 } // namespace
447 449
448 } // namespace chrome_browser_net 450 } // namespace chrome_browser_net
OLDNEW
« no previous file with comments | « chrome/browser/metrics/variations/variations_service_unittest.cc ('k') | chrome/browser/net/pref_proxy_config_tracker_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698