chrome/browser/ui/autofill/autofill_popup_controller_impl.cc - Issue 11740033: [Autofill] Add Mac implementation for the in-browser process popup view.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

Issue 11740033: [Autofill] Add Mac implementation for the in-browser process popup view. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/about_flags.cc ('K') | « chrome/browser/ui/autofill/autofill_popup_controller.h ('k') | chrome/browser/ui/autofill/autofill_popup_view.cc » ('j') | chrome/browser/ui/cocoa/autofill/autofill_popup_view_cocoa.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

index 6473184eadf65474d343151d4f7d8ea8de7e3194..e1dc38df1201d875977754ebdc28a86b2070132e 100644

--- a/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_popup_controller_impl.cc

@@ -191,6 +191,8 @@ int AutofillPopupControllerImpl::GetIconResourceID(

}

bool AutofillPopupControllerImpl::CanDelete(size_t index) {

+ // TODO(isherman): AddressBook suggestions on Mac should not be drawn as

+ // deleteable.

int id = identifiers_[index];

return id > 0 ||

id == WebAutofillClient::MenuItemIDAutocompleteEntry ||

@@ -432,6 +434,8 @@ bool AutofillPopupControllerImpl::RemoveSelectedLine() {

if (HasSuggestions()) {

delegate_->ClearPreviewedForm();

+ // TODO(isherman): This doesn't update the origin as it should on Mac, due

+ // to the flipped coordinate system.

UpdateBoundsAndRedrawPopup();

} else {

HideInternal();